Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comments): center align submit button in new comment field #46595

Merged
merged 5 commits into from
Jul 23, 2024

Conversation

edward-ly
Copy link
Contributor

@edward-ly edward-ly commented Jul 17, 2024

  • Resolves: (unknown, I was given this issue from a design review)

Summary

A quick and dirty fix for centering the submit button when the comments are first shown. If I have extra time, I could investigate alternative solutions that don't require hardcoded values.

Checklist

Before After
Screenshot 2024-07-17 at 16-45-04 Files - Nextcloud Screenshot 2024-07-17 at 16-45-23 Files - Nextcloud

@edward-ly edward-ly changed the title fix(comments): Center align submit button in new comment field fix(comments): center align submit button in new comment field Jul 17, 2024
@edward-ly
Copy link
Contributor Author

edward-ly commented Jul 18, 2024

If I have extra time, I could investigate alternative solutions that don't require hardcoded values.

I figured out how to do exactly that, with the added benefit being that the button remains centered regardless of the number of lines in the text box. Although, I'm not sure if that is preferable to before where the button is always on the last line, and the text may overlap with the button regardless.

983f121 8f11535
Screenshot 2024-07-17 at 21-11-02 Files - Nextcloud Screenshot 2024-07-17 at 21-04-00 Files - Nextcloud

@marcelklehr
Copy link
Member

Thanks for the PR, edward! I think, personally, I'd prefer 983f121, even if that is more of a dirty fix :D

Signed-off-by: Edward Ly <contact@edward.ly>
Signed-off-by: Edward Ly <contact@edward.ly>
@edward-ly edward-ly force-pushed the fix/comments/align-submit-button branch from 45859dc to 5a64828 Compare July 22, 2024 16:27
@edward-ly
Copy link
Contributor Author

Thanks for the PR, edward! I think, personally, I'd prefer 983f121, even if that is more of a dirty fix :D

Sorry for the wait, I reverted back to the quick and dirty fix now and cleaned up the branch commits.

@marcelklehr
Copy link
Member

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@marcelklehr marcelklehr merged commit f58a88b into master Jul 23, 2024
132 checks passed
Copy link

welcome bot commented Jul 23, 2024

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@marcelklehr marcelklehr deleted the fix/comments/align-submit-button branch July 23, 2024 07:46
@blizzz blizzz mentioned this pull request Jul 24, 2024
Copy link
Contributor

github-actions bot commented Aug 1, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants