Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theming): enforce theme should still provide dark as fallback #46504

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jul 13, 2024

Discovered from

Otherwise apps cannot enforce some areas of their UI to be dark, like the Modal component which is always dark.
Here is the result otherwise: image

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@@ -28,7 +28,7 @@ public function __construct(
private LoggerInterface $logger,
private DefaultTheme $defaultTheme,
LightTheme $lightTheme,
DarkTheme $darkTheme,
private DarkTheme $darkTheme,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why make it private?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it is now used in getThemesmethod, before this was not a class attribute but just a constructor parameter (it is now promoted as a private class attribute).

@skjnldsv skjnldsv merged commit b05e963 into master Jul 15, 2024
166 checks passed
@skjnldsv skjnldsv deleted the fix/dark-theme-enforce branch July 15, 2024 08:09
@ShGKme
Copy link
Contributor

ShGKme commented Jul 15, 2024

Backport?

@susnux
Copy link
Contributor

susnux commented Jul 15, 2024

/backport to stable29

@susnux
Copy link
Contributor

susnux commented Jul 15, 2024

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants