fix(files_metadata): Don't run generation job on every upgrade #46450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
added
bug
3. to review
|
/backport to stable29 |
|
/backport to stable28 |
nickvergessen
approved these changes
Jul 11, 2024
artonge
force-pushed
the
artonge/fix/prevent_generating_metadata_on_every_upgrade
branch
from
c100e1f
to
38de802
Compare
ArtificialOwl
approved these changes
Jul 16, 2024
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
artonge/fix/prevent_generating_metadata_on_every_upgrade
branch
from
38de802
to
f00aceb
Compare
artonge
deleted the
artonge/fix/prevent_generating_metadata_on_every_upgrade
branch
This was referenced Jul 16, 2024
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repair steps adds the background job on every upgrade, so not having an flag to indicated that it's done will make it start again every time.