perf: Set session.cache_limiter at runtime to avoid clients caching static assets served by PHP #46320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliushaertl
force-pushed
the
perf/php-session-cache-limiter
branch
from
0d98e08
to
9c76acb
Compare
juliushaertl
force-pushed
the
perf/php-session-cache-limiter
branch
from
9c76acb
to
189cd15
Compare
nickvergessen
approved these changes
Jul 8, 2024
…tatic assets served by PHP By default there is a Pragma: no-cache header set due to the default value `no-cache` of session.cache-limiter, which will cause Chrome and iOS to not cache even with a different Cache-Control header set on the response. Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
perf/php-session-cache-limiter
branch
from
189cd15
to
38bee2c
Compare
|
Seems we can't convince cypress, but to me it seems not related?? |
|
/backport to stable29 |
|
/backport to stable28 |
5 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default there is a Pragma: no-cache header set due to the default
value
no-cacheof session.cache-limiter, which will cause Chrome andiOS to not cache even with a different Cache-Control header set on the
response.
Signed-off-by: Julius Härtl jus@bitgrid.net
Summary
TODO
Checklist