feat: Add yieldEntities wrapper for entity mapping in QBMapper #45947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
approved these changes
Jun 19, 2024
ChristophWurst
added
the
pending documentation
come-nc
reviewed
Jun 20, 2024
juliushaertl
force-pushed
the
feat/qbmapper-yield-entities
branch
2 times, most recently
from
d57ec0d
to
7324687
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
feat/qbmapper-yield-entities
branch
from
7324687
to
2fb0ca9
Compare
nickvergessen
approved these changes
Jun 27, 2024
come-nc
approved these changes
Jun 27, 2024
| * @throws Exception | ||
| * @since 30.0.0 | ||
| */ | ||
| protected function yieldEntities(IQueryBuilder $query): Generator { |
There was a problem hiding this comment.
juliushaertl
added a commit
to nextcloud/documentation
that referenced
this pull request
Jul 19, 2024
nextcloud/server#45947 Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
removed
the
pending documentation
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be a nice small addition to the QBMapper API to allow apps iterating over results in a more memory efficient way that does not need to keep the full result set in memory.
Checklist