Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files_sharing): global search in sharing tab #45922

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

fix(files_sharing): global search in sharing tab #45922

wants to merge 4 commits into from

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jun 17, 2024

  • Resolves: clicking Global Search breaks the sharing tab

Summary

  • Probably a regression from new flow: Improve sharing flow #39472
  • In the past, on select it (in addShare):
    1. Checked if it was not the lookup = global search option
    2. Checked if it was not the external with custom handler option
    3. Created a share with default params
  • Then it was moved to a new create share details view
    • onSelect now simply opens the details view where the share can be created
    • p.2 is also moved to the SharingDetails
    • p.1 was missed

TODO

  • Migrate to new built-in NcSelect label
    image
  • Remove old now unused addShare method
  • Restore lookup select processing

Screenshots

🏚️ Before 🏡 After
global-search-sharing-before global-search-sharing-after

Checklist

@ShGKme ShGKme added this to the Nextcloud 30 milestone Jun 17, 2024
@ShGKme ShGKme requested review from susnux, nfebe, skjnldsv and Pytal June 17, 2024 14:19
@ShGKme ShGKme self-assigned this Jun 17, 2024
@ShGKme ShGKme marked this pull request as draft June 17, 2024 14:20
@ShGKme ShGKme changed the title fix(files_sharing ): global search in sharing tab fix(files_sharing): global search in sharing tab Jun 17, 2024
@ShGKme ShGKme marked this pull request as ready for review June 17, 2024 14:25
@ShGKme
Copy link
Contributor Author

ShGKme commented Jun 17, 2024

/backport to stable29

@ShGKme
Copy link
Contributor Author

ShGKme commented Jun 17, 2024

/backport to stable28

@ShGKme
Copy link
Contributor Author

ShGKme commented Jun 17, 2024

/backport to stable27

ShGKme added 4 commits June 21, 2024 12:31
@ShGKme
chore(files_sharing): use built-in label in search
cf138c1 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(files_sharing): remove unused method in SharingInput
363221f 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
fix(files_sharing): bring global search in Sharing Input
91da36b 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(assets): Recompile assets
5b3830c 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the fix/files_sharing--global-search-in-select branch from 25d6e8a to 5b3830c Compare June 21, 2024 11:45
@ShGKme
Copy link
Contributor Author

ShGKme commented Jun 21, 2024

Rebased onto master to resolve conflict and removed unused return value true

@ShGKme ShGKme enabled auto-merge June 21, 2024 11:46
susnux
susnux reviewed Jun 21, 2024
View reviewed changes
apps/files_sharing/src/components/SharingInput.vue
<NcSelect ref="select"
v-model="value"
input-id="sharing-search-input"
:input-label="t('files_sharing', 'Search for share recipients')"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks cypress tests.
I agree we do not need the ID but then you need to change the selector in the Cypress tests.

@ShGKme ShGKme marked this pull request as draft June 25, 2024 21:28
auto-merge was automatically disabled June 25, 2024 21:28

Pull request was converted to draft

@skjnldsv skjnldsv added the 2. developing Work in progress label Jul 27, 2024
@skjnldsv skjnldsv removed the 3. to review Waiting for reviews label Jul 27, 2024
@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@Pytal Pytal Pytal approved these changes

@nfebe nfebe Awaiting requested review from nfebe

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@ShGKme ShGKme

Labels
2. developing Work in progress backport-request bug feature: sharing
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
4 participants
@ShGKme @susnux @Pytal @skjnldsv