Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): Use data-cy (data attribute) instead of cy-data #45789

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 11, 2024

Summary

cy-data is a typo that introduces invalid HTML (unknown attribute), so lets fix it and use data-cy.

For 29 and 28 this is already fixed.

Checklist

@susnux susnux added this to the Nextcloud 30 milestone Jun 11, 2024
@susnux susnux requested review from artonge, Fenn-CS and Pytal June 11, 2024 13:37
@susnux susnux requested a review from skjnldsv as a code owner June 11, 2024 13:37
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@skjnldsv skjnldsv merged commit 0b10f2d into master Jun 12, 2024
109 checks passed
@skjnldsv skjnldsv deleted the fix/cy-selector branch June 12, 2024 08:08
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 12, 2024
@danxuliu
Copy link
Member

For 29 and 28 this is already fixed.

This is indeed fixed for stable28, but not for stable29; is it included in an still open pull request? Thanks :-)

@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants