fix: Autodetect legacy filekey instead of trusting the header for legacy header #45669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acy header Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
artonge
reviewed
Jun 5, 2024
|
We just tried this patch in a test environment and it seems to give access to the files that were broken before. (At least the ones in a moved folder, we haven't tested the files broken by resharing) |
Passing |
artonge
approved these changes
Jun 6, 2024
|
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
artonge
reviewed
Jun 6, 2024
|
Pushed commit to attempt to fix tests |
artonge
force-pushed
the
fix/fix-encryption-legacy-reshare
branch
from
5e297ff
to
01e3921
Compare
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
fix/fix-encryption-legacy-reshare
branch
from
01e3921
to
f244261
Compare
|
/backport to stable29 |
|
/backport to stable28 |
|
/backport to stable27 |
ChristophWurst
approved these changes
Jun 11, 2024
|
/backport to stable27 |
|
/backport to stable28 |
|
/backport to stable29 |
8 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When resharing, the filekey gets migrated to new encryption, but the header is untouched so it fails to open.
With this change we just autodetect which kind of filekey to use when opening unless we know for sure we do not need to use the old way.
Also refactored the decryptAll related code to use the same getFileKey method as the rest.
Should be tested.
Checklist