Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): reset menu pos when opening in grid mode #45581

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

skjnldsv
Copy link
Member

Fix #45556

@skjnldsv skjnldsv added bug 3. to review Waiting for reviews feature: files papercut Annoying recurring issue with possibly simple fix. labels May 30, 2024
@skjnldsv skjnldsv added this to the Nextcloud 30 milestone May 30, 2024
@skjnldsv skjnldsv requested review from blizzz, Pytal and a team May 30, 2024 10:17
@skjnldsv skjnldsv self-assigned this May 30, 2024
@skjnldsv skjnldsv requested review from Fenn-CS and sorbaugh and removed request for a team May 30, 2024 10:17
@skjnldsv
Copy link
Member Author

/backport to stable29

@skjnldsv
Copy link
Member Author

/backport to stable28

Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works! Assets have to be built though.

@skjnldsv
Copy link
Member Author

skjnldsv commented Jun 4, 2024

/compile rebase /

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 4, 2024
skjnldsv and others added 2 commits June 4, 2024 13:48
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv merged commit 3f77eb0 into master Jun 4, 2024
37 of 39 checks passed
@skjnldsv skjnldsv deleted the fix/grid-view-contextmenu-pos branch June 4, 2024 13:50
@skjnldsv
Copy link
Member Author

skjnldsv commented Jun 7, 2024

/backport to stable29

Copy link

backportbot bot commented Jun 7, 2024

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/45581/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick af5a29e5 43830558

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45581/stable29

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/45581/stable29."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish backport-request bug feature: files papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Right-click context menu on wrong position after switiching to grid view
4 participants