-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files): Implement SortingService
to fix sorting of files
#45419
Conversation
SortingService
to fix sorting of files
/backport to stable29 |
/backport to stable28 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having this in the @nextcloud/files
would be helpful 🙈
@skjnldsv what of this? The The only place I know where this could be reused would be the file picker. Or do you have something other in mind? |
Viewer |
But do we want to backport the files library update then on stable28 and stable29? If not we need to merge this for stable branches. |
Fair point!! Let's migrate this after backports to the lib ? |
Yes sounds good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
The previously used library was parsing strings to try to detect dates, but for filenames it makes no sense to parse them as dates. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Summary
The previously used library was parsing strings to try to detect dates, but for filenames it makes no sense to parse them as dates.
Overall the library is parsing a lot of stuff we do not need, so instead of a 3rd party library we can use the native browser solution and use
Intl.Collator
.Screenshots
Checklist