Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ability to sort by last login #45249

Merged
merged 25 commits into from
Jul 9, 2024
Merged

feat: add ability to sort by last login #45249

merged 25 commits into from
Jul 9, 2024

Commits on Jul 8, 2024

  1. feat: add ability to sort users by last_login, uid or displayName. on… 

    …e of these needs to be passed as orderBy and sort can be ASC or DESC

Signed-off-by: yemkareems <yemkareems@gmail.com>
    @yemkareems
    yemkareems committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    0ee676c View commit details
    Browse the repository at this point in the history

  2. feat: cs fix run on the changed files and default order by last_login… 

    … desc. Also last_login sort logic changed

Signed-off-by: yemkareems <yemkareems@gmail.com>
    @yemkareems
    yemkareems committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    87a8013 View commit details
    Browse the repository at this point in the history

  3. fix: sort the user getDisplayNames based on lastLogin. Default sort o… 

    …rder is lastLogin DESC

Signed-off-by: yemkareems <yemkareems@gmail.com>
    @yemkareems
    yemkareems committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    c8c68c3 View commit details
    Browse the repository at this point in the history

  4. fix: cs fix and psalm ci related changes 

    Signed-off-by: yemkareems <yemkareems@gmail.com>
    @yemkareems
    yemkareems committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    33b38c6 View commit details
    Browse the repository at this point in the history

  5. fix: change orderBy and sort to sortMode and sortOrder. default it to… 

    … uid asc. enable email search by changing query

Signed-off-by: yemkareems <yemkareems@gmail.com>
    @yemkareems
    yemkareems committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    76c875a View commit details
    Browse the repository at this point in the history

  6. fix: rebased the branch with master and resolved conflicts 

    fix: added a new endpoint users/recent and getting users based on last login info in the same. Reverted old code that was breaking LDAP

Signed-off-by: yemkareems <yemkareems@gmail.com>
    @yemkareems
    yemkareems committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    4cb85f7 View commit details
    Browse the repository at this point in the history

  7. fix: removed csrf check for the recent end point and ran cs fix 

    Signed-off-by: yemkareems <yemkareems@gmail.com>
    @yemkareems
    yemkareems committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    3615b1f View commit details
    Browse the repository at this point in the history

  8. fix: search and searchDisplayNames reverted to how it was initially a… 

    …s sort and order are not required here

Signed-off-by: yemkareems <yemkareems@gmail.com>
    @yemkareems
    yemkareems committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    dc6e8c9 View commit details
    Browse the repository at this point in the history

  9. fix: search and searchDisplayNames reverted to how it was initially a… 

    …s sort and order are not required here

Signed-off-by: yemkareems <yemkareems@gmail.com>
    @yemkareems
    yemkareems committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    695bd04 View commit details
    Browse the repository at this point in the history

  10. fix: doc blocks added 

    Signed-off-by: yemkareems <yemkareems@gmail.com>
    @yemkareems
    yemkareems committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    5b249df View commit details
    Browse the repository at this point in the history

  11. fix: since added to doc blocks 

    Signed-off-by: yemkareems <yemkareems@gmail.com>
    @yemkareems
    yemkareems committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    c701ef1 View commit details
    Browse the repository at this point in the history

  12. fix: removed the params related to sortMode and order since it sorts … 

    …by lastLogin

Signed-off-by: yemkareems <yemkareems@gmail.com>
    @yemkareems
    yemkareems committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    afa5136 View commit details
    Browse the repository at this point in the history

  13. fix: removed NoCSRFRequired used for testing locally 

    Signed-off-by: yemkareems <yemkareems@gmail.com>
    @yemkareems
    yemkareems committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    4c62f78 View commit details
    Browse the repository at this point in the history

  14. fix: removed references to old disabled users code. refactored query … 

    …as per getDisplayNames function. limit and offset added to query. default limit set to 25.

Signed-off-by: yemkareems <yemkareems@gmail.com>
    @yemkareems
    yemkareems committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    cfafbc8 View commit details
    Browse the repository at this point in the history

  15. fix: removed default limit of 25. if null is given all users are fetc… 

    …hed or if limit is given limit number of users are fetched

Signed-off-by: yemkareems <yemkareems@gmail.com>
    @yemkareems
    yemkareems committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    ceedfb4 View commit details
    Browse the repository at this point in the history

  16. fix: limit and fixLimit removed. negative limit handled in controller… 

    …. removed getUsersSortedByLastLogin from Manager and instead used the config in controller

Signed-off-by: yemkareems <yemkareems@gmail.com>
    @yemkareems
    yemkareems committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    ae95e46 View commit details
    Browse the repository at this point in the history

  17. fix: query refactored to support both the search by email and sort by… 

    … login

Signed-off-by: yemkareems <yemkareems@gmail.com>
    @yemkareems
    yemkareems committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    0e60402 View commit details
    Browse the repository at this point in the history

  18. fix: second join and where conditions added only when search param is… 

    … available

Signed-off-by: yemkareems <yemkareems@gmail.com>
    @yemkareems
    yemkareems committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    3dee8a2 View commit details
    Browse the repository at this point in the history

  19. fix: return type doc block added as per psalm 

    Signed-off-by: yemkareems <yemkareems@gmail.com>
    @yemkareems
    yemkareems committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    0df1a29 View commit details
    Browse the repository at this point in the history

  20. fix: return type doc block added as per psalm 

    Signed-off-by: yemkareems <yemkareems@gmail.com>
    @yemkareems
    yemkareems committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    53e3644 View commit details
    Browse the repository at this point in the history

  21. fix: return type doc block added as per psalm 

    Signed-off-by: yemkareems <yemkareems@gmail.com>
    @yemkareems
    yemkareems committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    357786f View commit details
    Browse the repository at this point in the history

  22. fix: doc block corrected 

    Signed-off-by: yemkareems <yemkareems@gmail.com>
    @yemkareems
    yemkareems committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    710dc43 View commit details
    Browse the repository at this point in the history

  23. fix: ran bash build/openapi-checker.sh and commit the result 

    Signed-off-by: yemkareems <yemkareems@gmail.com>
    @yemkareems
    yemkareems committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    6ac49e5 View commit details
    Browse the repository at this point in the history

  24. fix: getLastLoggedInUsers moved from AllConfig/IConfig to IUserManage… 

    …r/Manager

Signed-off-by: yemkareems <yemkareems@gmail.com>
    @yemkareems
    yemkareems committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    4eba967 View commit details
    Browse the repository at this point in the history

  25. fix(OpenAPI): Regenerate 

    Signed-off-by: provokateurin <kate@provokateurin.de>
    @provokateurin
    provokateurin committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    68d60fc View commit details
    Browse the repository at this point in the history