fix: fix FileAccess::getByFileId(InStorage) #45140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
requested review from
a team,
ArtificialOwl,
Fenn-CS and
yemkareems
and removed request for
a team
|
/backport to stable29 |
1 task
kesselb
approved these changes
May 2, 2024
come-nc
reviewed
May 2, 2024
| @@ -56,7 +56,7 @@ private function getQuery(): CacheQueryBuilder { | |||
| } | |||
|
|
|||
| public function getByFileIdInStorage(int $fileId, int $storageId): ?CacheEntry { | |||
| $items = $this->getByFileIdsInStorage([$fileId], $storageId); | |||
| $items = array_values($this->getByFileIdsInStorage([$fileId], $storageId)); | |||
| return $items[0] ?? null; | |||
There was a problem hiding this comment.
Suggested change
| return $items[0] ?? null; | |
| return reset($items) ?: null; |
And then you do not need the array_values call.
But no idea if it’s more performant.
It just sucks that array_value_first did not make it in 😿 https://wiki.php.net/rfc/array_key_first_last#vote
There was a problem hiding this comment.
Performance seems to be quite the same, ~10% difference (faster array_values) on my system.
come-nc
approved these changes
May 2, 2024
susnux
approved these changes
May 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.