fix(files): Use OCP\Util::getForbiddenFileNameChars instead of directaccess to system config #44996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
approved these changes
Apr 24, 2024
Altahrim
approved these changes
Apr 24, 2024
susnux
force-pushed
the
fix/unify-access-to-forbidden-chars
branch
from
8572402
to
40cad81
Compare
come-nc
approved these changes
Apr 29, 2024
… access to system config Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/unify-access-to-forbidden-chars
branch
from
40cad81
to
6a281f0
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We (might) extend it in the future so we should only use one common place (OCP\Util) for getting forbidden characters.
Checklist