Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #42647 Unnecessary 2FA UI message #44585

Closed
wants to merge 4 commits into from

Conversation

jadjoud
Copy link
Contributor

@jadjoud jadjoud commented Mar 30, 2024

Summary

Added a conditional statement of the message rendering

image

image

TODO

  • ...

Checklist

Signed-off-by: JEEEEEEEEEEEEEEEEEEEEEED <118366366+jadjoud@users.noreply.github.com>
Signed-off-by: JEEEEEEEEEEEEEEEEEEEEEED <118366366+jadjoud@users.noreply.github.com>
Signed-off-by: JEEEEEEEEEEEEEEEEEEEEEED <118366366+jadjoud@users.noreply.github.com>
@jadjoud jadjoud requested a review from skjnldsv as a code owner March 30, 2024 13:09
@kesselb
Copy link
Contributor

kesselb commented Mar 31, 2024

Hi and thanks for your pull request 👍

This pr also includes your other patch. Please try to rebase and drop the other commit.

Please also try to squash the copyright commit into the actual commit .

We are using https://www.conventionalcommits.org/en/v1.0.0/ and therefore it would be nice when your commit message also uses it. Tip: interactive rebase to reword a commit message.

@jadjoud
Copy link
Contributor Author

jadjoud commented Mar 31, 2024

Thank you for your help @kesselb

This is the new fixed PR #44594

@jadjoud jadjoud closed this Mar 31, 2024
@jadjoud jadjoud deleted the jedFix#42647 branch March 31, 2024 14:42
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary 2FA UI message in Files settings
2 participants