Skip to content

fix(files): provide onDestroy callback for interactive widgets #44226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Antreesy merged 1 commit into from
Mar 16, 2024
Merged

fix(files): provide onDestroy callback for interactive widgets #44226

Antreesy merged 1 commit into from
Mar 16, 2024

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Mar 15, 2024

  • Resolves: regression from bfa65cf

Summary

registerWidget expects 4 arguments:

  • id
  • callback
  • onDestroy callback (was missing)
  • params object

That results in TypeError:
image

Checklist

@Antreesy Antreesy added this to the Nextcloud 29 milestone Mar 15, 2024
@Antreesy Antreesy requested review from juliusknorr and susnux March 15, 2024 15:33
@Antreesy Antreesy self-assigned this Mar 15, 2024
@Antreesy Antreesy requested a review from skjnldsv as a code owner March 15, 2024 15:33
@Antreesy

This comment was marked as resolved.

Sign in to view
@Antreesy Antreesy requested a review from ShGKme March 15, 2024 15:41
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 15, 2024
@Antreesy Antreesy force-pushed the fix/noid/widget-ondestroy-callback branch from 5fc6ef9 to f8c8f93 Compare March 15, 2024 15:51
@Antreesy Antreesy enabled auto-merge March 15, 2024 15:52
@Antreesy

This comment was marked as duplicate.

Sign in to view
@Antreesy Antreesy force-pushed the fix/noid/widget-ondestroy-callback branch from d991bbf to 7aec654 Compare March 16, 2024 06:12
@Antreesy
Copy link
Contributor Author

Antreesy commented Mar 16, 2024

/compile amend

@Antreesy @nextcloud-command
fix(files): provide onDestroy callback for interactive widgets
0af93c8 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the fix/noid/widget-ondestroy-callback branch from 7aec654 to 0af93c8 Compare March 16, 2024 06:18
@Antreesy Antreesy merged commit 90e09a2 into master Mar 16, 2024
@Antreesy Antreesy deleted the fix/noid/widget-ondestroy-callback branch March 16, 2024 06:38
@Altahrim Altahrim mentioned this pull request Mar 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ShGKme ShGKme ShGKme approved these changes

Assignees

@Antreesy Antreesy

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: files

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

6 participants

@Antreesy @susnux @juliusknorr @skjnldsv @ShGKme