Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(files): add Viewer Files ressource handler #44012

Merged
merged 4 commits into from
Mar 7, 2024
Merged

feat(files): add Viewer Files ressource handler #44012

merged 4 commits into from
Mar 7, 2024

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Mar 5, 2024 •
edited
Loading

@skjnldsv skjnldsv added this to the Nextcloud 29 milestone Mar 5, 2024
@skjnldsv skjnldsv self-assigned this Mar 5, 2024
@juliusknorr juliusknorr mentioned this pull request Mar 6, 2024
Merged
1 task
@skjnldsv skjnldsv mentioned this pull request Mar 6, 2024
Merged
@skjnldsv skjnldsv force-pushed the feat/live-file-reference branch 4 times, most recently from efcb9b0 to 0d0cbe3 Compare March 6, 2024 17:29
@skjnldsv skjnldsv marked this pull request as ready for review March 6, 2024 17:30
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 6, 2024
AndyScherzinger
AndyScherzinger approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@skjnldsv skjnldsv mentioned this pull request Mar 6, 2024
Closed
@juliusknorr
Copy link
Member

Pushed a small addition to fix other viewer components I've tested (text/files_pdfviewer), hope that is fine

@juliusknorr juliusknorr mentioned this pull request Mar 7, 2024
Merged
@skjnldsv
Copy link
Member Author

skjnldsv commented Mar 7, 2024

AH, I changed the active on purpose, otherwise the video auto plays :)
I guess we should better link it to the visible state of the Widget api?

@juliusknorr
Copy link
Member

Ok, I see, I added that for text as we there do not load the file until active is set, but I can work around that in text.

skjnldsv added 2 commits March 7, 2024 11:06
@skjnldsv
feat(files): add Viewer Files ressource handler
bfa65cf 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
feat(files): add Folder Preview ressource handler
3f8a66f 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv and others added 2 commits March 7, 2024 11:06
@skjnldsv
chore(deps): bump @nextcloud/vue to 8.9.1 & @nextcloud/dialogs to 5.2.0
cc93ce6 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@juliusknorr @skjnldsv
fix: Positioning and active state of viewer components
bebf1e1 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@skjnldsv skjnldsv force-pushed the feat/live-file-reference branch from 8a4cb21 to bebf1e1 Compare March 7, 2024 10:10
@skjnldsv skjnldsv merged commit 32f5a15 into master Mar 7, 2024
85 of 89 checks passed
@skjnldsv skjnldsv deleted the feat/live-file-reference branch March 7, 2024 10:22
@juliusknorr juliusknorr mentioned this pull request Mar 8, 2024
Merged
4 tasks
@juliusknorr juliusknorr mentioned this pull request Mar 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@susnux susnux Awaiting requested review from susnux

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

@artonge artonge Awaiting requested review from artonge

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews enhancement feature: files
Projects
Files to vue
Status: Done
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

🍱 Interactive widget: folder 🍱 Interactive widget: file
3 participants
@skjnldsv @juliusknorr @AndyScherzinger