Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable25] Check share status when touching versions #43859

Merged
merged 1 commit into from
Feb 27, 2024
Merged

[stable25] Check share status when touching versions #43859

merged 1 commit into from
Feb 27, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Feb 27, 2024 •
edited by artonge
Loading

Backport of #43727

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from skjnldsv, susnux and artonge February 27, 2024 09:48
@backportbot backportbot bot added 3. to review Waiting for reviews feature: versions javascript php Pull requests that update Php code labels Feb 27, 2024
@artonge artonge force-pushed the backport/43727/stable25 branch 3 times, most recently from bc3a1f1 to 998d3bc Compare February 27, 2024 10:06
@artonge artonge marked this pull request as ready for review February 27, 2024 10:06
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 27, 2024
View reviewed changes
apps/dav/lib/DAV/ViewOnlyPlugin.php Fixed Show fixed Hide fixed
apps/dav/lib/DAV/ViewOnlyPlugin.php Fixed Show fixed Hide fixed
apps/dav/lib/DAV/ViewOnlyPlugin.php Fixed Show fixed Hide fixed
apps/dav/lib/DAV/ViewOnlyPlugin.php Fixed Show fixed Hide fixed
apps/dav/lib/DAV/ViewOnlyPlugin.php Fixed Show fixed Hide fixed
@artonge artonge force-pushed the backport/43727/stable25 branch from 998d3bc to 26eae60 Compare February 27, 2024 10:34
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 27, 2024
View reviewed changes
apps/dav/lib/DAV/ViewOnlyPlugin.php Dismissed Show dismissed Hide dismissed
@artonge
Copy link
Contributor

artonge commented Feb 27, 2024

/backport to stable24

@artonge
Check share attributes when downloading versions
4c289aa 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the backport/43727/stable25 branch from 26eae60 to 4c289aa Compare February 27, 2024 11:08
@artonge
Copy link
Contributor

artonge commented Feb 27, 2024

CI failure unrelated

@artonge artonge added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 27, 2024
@sorbaugh sorbaugh merged commit 00bee4f into stable25 Feb 27, 2024
28 of 30 checks passed
@sorbaugh sorbaugh deleted the backport/43727/stable25 branch February 27, 2024 13:18
@backportbot backportbot bot mentioned this pull request Feb 27, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfebe nfebe nfebe approved these changes

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@susnux susnux Awaiting requested review from susnux

Assignees

@artonge artonge

Labels
4. to release Ready to be released and/or waiting for tests to finish feature: versions javascript php Pull requests that update Php code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artonge @nfebe @sorbaugh