Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check share status when touching versions #43727

Merged
merged 5 commits into from
Feb 21, 2024
Merged

Check share status when touching versions #43727

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8e95d0f
Check share attributes when downloading versions
artonge Feb 13, 2024
741dec2
Check node permissions when deleting a version
artonge Feb 13, 2024
37d0fd1
Check node permissions when restoring a version
artonge Feb 13, 2024
046b8f3
Check permissions when labeling a version
artonge Feb 21, 2024
18b32e8
Hide some actions based on node permissions and share attributes
artonge Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Check permissions when labeling a version 
Signed-off-by: Louis Chemineau <louis@chmn.me>
  • Loading branch information
@artonge
artonge committed Feb 21, 2024
commit 046b8f320f2ce1c37f658130ec84071218262deb
4 changes: 4 additions & 0 deletions apps/files_versions/lib/Versions/LegacyVersionsBackend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,10 @@ public function getVersionFile(IUser $user, FileInfo $sourceFile, $revision): Fi
}

public function setVersionLabel(IVersion $version, string $label): void {
if (!$this->currentUserHasPermissions($version, \OCP\Constants::PERMISSION_UPDATE)) {
throw new Forbidden('You cannot label this version because you do not have update permissions on the source file.');
}

$versionEntity = $this->versionsMapper->findVersionForFileId(
$version->getSourceFile()->getId(),
$version->getTimestamp(),
Expand Down