Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merge conflict dialog added when overwriting files on move-file action #43667

Merged
merged 4 commits into from
Feb 24, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: conflict picker moves files correctly to its directory
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
  • Loading branch information
emoral435 committed Feb 24, 2024
commit 67b0c7ce142595f71cfa6655d46bc57dd8e1ce90
31 changes: 26 additions & 5 deletions apps/files/src/actions/moveOrCopyAction.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import { emit } from '@nextcloud/event-bus'
import { FilePickerClosed, getFilePickerBuilder, showError } from '@nextcloud/dialogs'
import { Permission, FileAction, FileType, NodeStatus, davGetClient, davRootPath, davResultToNode, davGetDefaultPropfind } from '@nextcloud/files'
import { translate as t } from '@nextcloud/l10n'
import { openConflictPicker, hasConflict } from '@nextcloud/upload'
import { getUploader, openConflictPicker, hasConflict } from '@nextcloud/upload'
import Vue from 'vue'

import CopyIconSvg from '@mdi/svg/svg/folder-multiple.svg?raw'
Expand Down Expand Up @@ -136,13 +136,34 @@ export const handleCopyMoveNodeTo = async (node: Node, destination: Folder, meth
}
} else {
// show conflict file popup if we do not allow overwriting
if (!overwrite) {
const contents = await getContents(destinationPath)
if (hasConflict([node], contents.contents)) {
await openConflictPicker
logger.debug("NO CONFLICTS SHOULD BE FOUND11")
const otherNodes = await getContents(destination.path)
logger.debug("NO CONFLICTS SHOULD BE FOUND2")
let files: (Node|File)[] = [node]
if (hasConflict([node], otherNodes.contents)) {
const conflicts = otherNodes.contents.filter((otherNode: Node) => {
return otherNode.basename === node.basename
}).filter(Boolean) as Node[]

const uploads = otherNodes.contents.filter((otherNode: Node) => {
return !conflicts.includes(otherNode)
})

try {
// Let the user choose what to do with the conflicting files
const { selected, renamed } = await openConflictPicker(destination.path, conflicts, otherNodes.contents)
files = [...uploads, ...selected, ...renamed]
} catch (error) {
// User cancelled
showError(t('files','Upload cancelled'))
emoral435 marked this conversation as resolved.
Show resolved Hide resolved
return
}

}

logger.debug("NO CONFLICTS SHOULD BE FOUND")
await client.moveFile(currentPath, join(destinationPath, node.basename))
logger.debug("FINALLY DELETE THE NODE")
// Delete the node as it will be fetched again
// when navigating to the destination folder
emit('files:node:deleted', node)
Expand Down