Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Update psalm-baseline.xml #43379

Merged
merged 1 commit into from
Feb 6, 2024
Merged

[master] Update psalm-baseline.xml #43379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update psalm baseline 
Signed-off-by: GitHub <noreply@github.com>
  • Loading branch information
@nextcloud-command
nextcloud-command authored Feb 6, 2024
commit 3c42a3e3dbbf4b1c7f7a48e035325b2cf315956b
55 changes: 0 additions & 55 deletions build/psalm-baseline-ocp.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,31 +58,6 @@
<code>IteratorAggregate</code>
</MissingTemplateParam>
</file>
<file src="lib/public/Federation/Exceptions/ActionNotSupportedException.php">
<UndefinedClass>
<code>\OC</code>
</UndefinedClass>
</file>
<file src="lib/public/Federation/Exceptions/AuthenticationFailedException.php">
<UndefinedClass>
<code>\OC</code>
</UndefinedClass>
</file>
<file src="lib/public/Federation/Exceptions/BadRequestException.php">
<UndefinedClass>
<code>\OC</code>
</UndefinedClass>
</file>
<file src="lib/public/Federation/Exceptions/ProviderAlreadyExistsException.php">
<UndefinedClass>
<code>\OC</code>
</UndefinedClass>
</file>
<file src="lib/public/Federation/Exceptions/ProviderDoesNotExistsException.php">
<UndefinedClass>
<code>\OC</code>
</UndefinedClass>
</file>
<file src="lib/public/Files.php">
<FalsableReturnStatement>
<code>\OC_App::getStorage($app)</code>
Expand All @@ -96,36 +71,6 @@
<code>ArrayAccess</code>
</MissingTemplateParam>
</file>
<file src="lib/public/Files/LockNotAcquiredException.php">
<UndefinedClass>
<code>\OC</code>
</UndefinedClass>
</file>
<file src="lib/public/Files/StorageAuthException.php">
<UndefinedClass>
<code>\OC</code>
</UndefinedClass>
</file>
<file src="lib/public/Files/StorageBadConfigException.php">
<UndefinedClass>
<code>\OC</code>
</UndefinedClass>
</file>
<file src="lib/public/Files/StorageConnectionException.php">
<UndefinedClass>
<code>\OC</code>
</UndefinedClass>
</file>
<file src="lib/public/Files/StorageNotAvailableException.php">
<UndefinedClass>
<code>\OC</code>
</UndefinedClass>
</file>
<file src="lib/public/Files/StorageTimeoutException.php">
<UndefinedClass>
<code>\OC</code>
</UndefinedClass>
</file>
<file src="lib/public/L10N/ILanguageIterator.php">
<MissingTemplateParam>
<code>\Iterator</code>
Expand Down
67 changes: 31 additions & 36 deletions build/psalm-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@
</RedundantCast>
<RedundantCondition>
<code><![CDATA[!empty($modified['old']) && is_array($modified['old'])]]></code>
<code><![CDATA[is_array($modified['old'])]]></code>
<code>is_array($modified['old'])</code>
</RedundantCondition>
</file>
<file src="apps/dav/lib/CalDAV/Schedule/IMipService.php">
Expand All @@ -323,8 +323,8 @@
</file>
<file src="apps/dav/lib/CalDAV/Schedule/Plugin.php">
<InvalidArgument>
<code><![CDATA[[$aclPlugin, 'propFind']]]></code>
<code><![CDATA[[$aclPlugin, 'propFind']]]></code>
<code>[$aclPlugin, 'propFind']</code>
<code>[$aclPlugin, 'propFind']</code>
</InvalidArgument>
<LessSpecificReturnStatement>
<code><![CDATA[$vevent->DTEND]]></code>
Expand Down Expand Up @@ -359,12 +359,12 @@
</file>
<file src="apps/dav/lib/CalDAV/Search/Xml/Request/CalendarSearchReport.php">
<TypeDoesNotContainType>
<code><![CDATA[!is_array($newProps['filters']['comps'])]]></code>
<code><![CDATA[!is_array($newProps['filters']['params'])]]></code>
<code><![CDATA[!is_array($newProps['filters']['props'])]]></code>
<code><![CDATA[!isset($newProps['filters']['comps']) || !is_array($newProps['filters']['comps'])]]></code>
<code><![CDATA[!isset($newProps['filters']['params']) || !is_array($newProps['filters']['params'])]]></code>
<code><![CDATA[!isset($newProps['filters']['props']) || !is_array($newProps['filters']['props'])]]></code>
<code>!is_array($newProps['filters']['comps'])</code>
<code>!is_array($newProps['filters']['params'])</code>
<code>!is_array($newProps['filters']['props'])</code>
<code>!isset($newProps['filters']['comps']) || !is_array($newProps['filters']['comps'])</code>
<code>!isset($newProps['filters']['params']) || !is_array($newProps['filters']['params'])</code>
<code>!isset($newProps['filters']['props']) || !is_array($newProps['filters']['props'])</code>
</TypeDoesNotContainType>
</file>
<file src="apps/dav/lib/CalDAV/WebcalCaching/RefreshWebcalService.php">
Expand Down Expand Up @@ -400,7 +400,7 @@
<code>VCard</code>
</MoreSpecificReturnType>
<TypeDoesNotContainType>
<code><![CDATA[$addressBooks[$row['id']][$readOnlyPropertyName] === 0]]></code>
<code>$addressBooks[$row['id']][$readOnlyPropertyName] === 0</code>
</TypeDoesNotContainType>
</file>
<file src="apps/dav/lib/CardDAV/MultiGetExportPlugin.php">
Expand Down Expand Up @@ -502,7 +502,7 @@
<code>bool</code>
</InvalidNullableReturnType>
<TooManyArguments>
<code><![CDATA[new PreconditionFailed('Cannot filter by non-existing tag', 0, $e)]]></code>
<code>new PreconditionFailed('Cannot filter by non-existing tag', 0, $e)</code>
</TooManyArguments>
<UndefinedClass>
<code>\OCA\Circles\Api\v1\Circles</code>
Expand Down Expand Up @@ -768,7 +768,7 @@
</file>
<file src="apps/encryption/lib/Crypto/Crypt.php">
<TypeDoesNotContainType>
<code><![CDATA[get_class($res) === 'OpenSSLAsymmetricKey']]></code>
<code>get_class($res) === 'OpenSSLAsymmetricKey'</code>
</TypeDoesNotContainType>
</file>
<file src="apps/encryption/lib/Crypto/Encryption.php">
Expand All @@ -783,7 +783,7 @@
</file>
<file src="apps/encryption/lib/Session.php">
<TooManyArguments>
<code><![CDATA[new Exceptions\PrivateKeyMissingException('please try to log-out and log-in again', 0)]]></code>
<code>new Exceptions\PrivateKeyMissingException('please try to log-out and log-in again', 0)</code>
</TooManyArguments>
</file>
<file src="apps/encryption/lib/Util.php">
Expand Down Expand Up @@ -811,7 +811,7 @@
<code>$shareId</code>
<code>$shareId</code>
<code>$shareId</code>
<code><![CDATA[(int)$data['id']]]></code>
<code>(int)$data['id']</code>
</InvalidArgument>
<LessSpecificReturnStatement>
<code>$nodes[0]</code>
Expand Down Expand Up @@ -841,7 +841,7 @@
<code>string</code>
</InvalidReturnType>
<InvalidScalarArgument>
<code><![CDATA[(int)$share['id']]]></code>
<code>(int)$share['id']</code>
</InvalidScalarArgument>
</file>
<file src="apps/federation/lib/DbHandler.php">
Expand Down Expand Up @@ -1069,7 +1069,7 @@
</file>
<file src="apps/files_sharing/templates/public.php">
<RedundantCondition>
<code><![CDATA[$_['hideFileList'] !== true]]></code>
<code>$_['hideFileList'] !== true</code>
<code><![CDATA[isset($_['hideFileList']) && $_['hideFileList'] !== true]]></code>
</RedundantCondition>
</file>
Expand Down Expand Up @@ -1206,7 +1206,7 @@
<file src="apps/sharebymail/lib/ShareByMailProvider.php">
<InvalidArgument>
<code><![CDATA[$share->getId()]]></code>
<code><![CDATA[(int)$data['id']]]></code>
<code>(int)$data['id']</code>
</InvalidArgument>
</file>
<file src="apps/systemtags/lib/Activity/Listener.php">
Expand Down Expand Up @@ -1716,7 +1716,7 @@
</file>
<file src="lib/private/AppFramework/Routing/RouteConfig.php">
<InvalidArrayOffset>
<code><![CDATA[$action['url-postfix']]]></code>
<code>$action['url-postfix']</code>
</InvalidArrayOffset>
</file>
<file src="lib/private/AppFramework/Services/AppConfig.php">
Expand Down Expand Up @@ -1946,7 +1946,7 @@
<code>getParams</code>
</InternalMethod>
<InvalidArrayOffset>
<code><![CDATA[$params['collation']]]></code>
<code>$params['collation']</code>
</InvalidArrayOffset>
</file>
<file src="lib/private/DB/Connection.php">
Expand All @@ -1957,8 +1957,8 @@
<code>$params</code>
</InvalidArgument>
<InvalidArrayOffset>
<code><![CDATA[$params['adapter']]]></code>
<code><![CDATA[$params['tablePrefix']]]></code>
<code>$params['adapter']</code>
<code>$params['tablePrefix']</code>
</InvalidArrayOffset>
</file>
<file src="lib/private/DB/Exceptions/DbalException.php">
Expand Down Expand Up @@ -1991,7 +1991,7 @@
<code>getParams</code>
</InternalMethod>
<InvalidArrayOffset>
<code><![CDATA[$params['collation']]]></code>
<code>$params['collation']</code>
</InvalidArrayOffset>
</file>
<file src="lib/private/DB/QueryBuilder/QueryBuilder.php">
Expand Down Expand Up @@ -2186,10 +2186,10 @@
<code>$user</code>
</InvalidOperand>
<RedundantCondition>
<code><![CDATA[get_class($provider) !== 'OCA\Files_Sharing\MountProvider']]></code>
<code>get_class($provider) !== 'OCA\Files_Sharing\MountProvider'</code>
</RedundantCondition>
<TypeDoesNotContainType>
<code><![CDATA[get_class($provider) === 'OCA\Files_Sharing\MountProvider']]></code>
<code>get_class($provider) === 'OCA\Files_Sharing\MountProvider'</code>
</TypeDoesNotContainType>
</file>
<file src="lib/private/Files/Config/UserMountCache.php">
Expand Down Expand Up @@ -2342,11 +2342,6 @@
<code>remove</code>
</UndefinedMethod>
</file>
<file src="lib/private/Files/ObjectStore/HomeObjectStoreStorage.php">
<ImplementedReturnTypeMismatch>
<code>false|string</code>
</ImplementedReturnTypeMismatch>
</file>
<file src="lib/private/Files/ObjectStore/ObjectStoreStorage.php">
<InvalidScalarArgument>
<code>$source</code>
Expand All @@ -2364,7 +2359,7 @@
<code>Promise\promise_for(
new Credentials($key, $secret)
)</code>
<code><![CDATA[\Aws\or_chain([self::class, 'legacySignatureProvider'], ClientResolver::_default_signature_provider())]]></code>
<code>\Aws\or_chain([self::class, 'legacySignatureProvider'], ClientResolver::_default_signature_provider())</code>
</UndefinedFunction>
</file>
<file src="lib/private/Files/ObjectStore/S3ObjectTrait.php">
Expand Down Expand Up @@ -2612,8 +2607,8 @@
<code>false</code>
</InvalidArgument>
<InvalidArrayOffset>
<code><![CDATA[$app['path']]]></code>
<code><![CDATA[$app['path']]]></code>
<code>$app['path']</code>
<code>$app['path']</code>
</InvalidArrayOffset>
<NullArgument>
<code>null</code>
Expand Down Expand Up @@ -2961,7 +2956,7 @@
</file>
<file src="lib/private/Setup.php">
<RedundantCondition>
<code><![CDATA[$type === 'pdo']]></code>
<code>$type === 'pdo'</code>
</RedundantCondition>
<UndefinedVariable>
<code>$vendor</code>
Expand Down Expand Up @@ -2991,7 +2986,7 @@
<InvalidArgument>
<code><![CDATA[$share->getId()]]></code>
<code><![CDATA[$share->getId()]]></code>
<code><![CDATA[(int)$data['id']]]></code>
<code>(int)$data['id']</code>
</InvalidArgument>
<TooManyArguments>
<code>set</code>
Expand Down Expand Up @@ -3189,8 +3184,8 @@
<code>$groupsList</code>
</InvalidArgument>
<InvalidArrayOffset>
<code><![CDATA[$dir['path']]]></code>
<code><![CDATA[$dir['url']]]></code>
<code>$dir['path']</code>
<code>$dir['url']</code>
</InvalidArrayOffset>
<NullArgument>
<code>null</code>
Expand Down
Loading