fix(ContactsStore): Sanitize user ID given to guest avatar route#43317
Merged
fix(ContactsStore): Sanitize user ID given to guest avatar route#43317
Conversation
It is not allowed to use slashes within path parameters, so they would need to be encoded. But URL encoded slashes are not suported by Apache, so instead replace slash with space. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
added
bug
3. to review
susnux
requested review from
a team,
Altahrim,
ArtificialOwl,
icewind1991 and
szaimen
and removed request for
a team
Contributor
Author
|
/backport to stable28 |
szaimen
approved these changes
Feb 5, 2024
Contributor
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
I guess makes sense but did not test
icewind1991
approved these changes
Feb 7, 2024
Merged
|
Sorry if I'm not supposed to write here and I have absolutely no idea if this is already released in 28.0.3, but if that is the case, it didn't work. I'm still getting the exception in the log for contacts#3800 / nextcloud/contacts#3479. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is not allowed to use slashes within path parameters, so they would need to be encoded. But URL encoded slashes are not supported by Apache, so instead replace slash with space.
Checklist