-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: personal file view #43211
feature: personal file view #43211
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
a994ff3
to
866e810
Compare
TLDR for the reviewers:
If anything needs clarification, just let me know! |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
@nimishavijay This is how the implementation looks! IMO, I think that having this now makes this view look a bit different from the rest - I think that having the rest of the views have something similar where we append the view name at the end of the file name would now make this much cleaner, no? This is certainly possible as well. EDIT: also talked with @skjnldsv and we agreed that the breadcrumbs, in our personal opinion, should have this change applied to each view :) it would easy to implement as well! EDIT2: cc @nimishavijay , forgot to cc again last week after guided PR with frontenders😅 |
UPDATE: We need to get this issue merged in ASAP for the next major release, so for now, the design aspect with the breadcrumbs can be left for another PR! Will adjust this accordingly, leaving the other PR that may be used for later! |
d156fa6
to
22d41d3
Compare
22d41d3
to
7e220cc
Compare
got approval on talk from design team that everything is good now :)
6863069
to
8226e26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One lint issue, otherwise LGTM
8226e26
to
8e681fd
Compare
Enabling auto-merge to hopefully get the feature out by Thursday night 👍 |
8e681fd
to
3c9e1fc
Compare
Why is psalm suddenly failing 🤦 |
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
915ecf5
to
0fa226e
Compare
Issue Summary
Resolves #42919
OVERVIEW / FRONTEND LOOK
Quick GIF View
File sharing comparison
Clarifications
Implementation
TODO
Checklist