Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files_sharing): Return focus to trigger element on sharing details close #43137

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jan 26, 2024

Summary

  • Switch v-if to v-show to preserve same instance of return focus element instead of mounting a new element on close
  • Return focus to triggering element

Checklist

@Pytal Pytal added this to the Nextcloud 29 milestone Jan 26, 2024
@Pytal Pytal self-assigned this Jan 26, 2024
@Pytal
Copy link
Member Author

Pytal commented Jan 26, 2024

Tip: Hide whitespace 😉

Pytal added 2 commits January 26, 2024 11:21
…s close

Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the fix/a11y/sharing-details-focus branch from ffebd2b to e6802d2 Compare January 26, 2024 19:24
@Pytal
Copy link
Member Author

Pytal commented Jan 26, 2024

/backport 22ab251 to stable28

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 26, 2024
@Pytal Pytal enabled auto-merge January 26, 2024 19:27
@Pytal Pytal merged commit 01520d5 into master Jan 26, 2024
62 checks passed
@Pytal Pytal deleted the fix/a11y/sharing-details-focus branch January 26, 2024 19:53
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility bug feature: sharing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants