Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

theming: Separate primary and background colors - fix the header menu colors #42977

Merged
merged 17 commits into from
May 21, 2024
Merged

theming: Separate primary and background colors - fix the header menu colors #42977

merged 17 commits into from
May 21, 2024

Commits on May 21, 2024

  1. fix(theming): Also set default background color ("primary") for custo… 

    …m images

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux
    susnux committed May 21, 2024
    Configuration menu
    Copy the full SHA
    0211feb View commit details
    Browse the repository at this point in the history

  2. feat(theming): Separate background and primary color 

    While the primary color is intended to highlight elements,
it can not always be used as the background color.
So now primary is independent from background a user set,
the background color is, if not set directly, calculated as the mean color
of the background image. That color is then used as a fallback if the
background image could not be loaded and for calculating the color of the text used on the app menu and dashboard (they render directly on the background).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux
    susnux committed May 21, 2024
    Configuration menu
    Copy the full SHA
    de938bb View commit details
    Browse the repository at this point in the history

  3. fix: Adjust dashboard and header menu to use new background colors 

    fix(UnifiedSearch): Adjust to new background color

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux
    susnux committed May 21, 2024
    Configuration menu
    Copy the full SHA
    9d2c3c1 View commit details
    Browse the repository at this point in the history

  4. feat(theming): Allow to configure primary color separate from backgro… 

    …und in admin settings

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux
    susnux committed May 21, 2024
    Configuration menu
    Copy the full SHA
    705335e View commit details
    Browse the repository at this point in the history

  5. fix(theming): Also reset background color settings when updating glob… 

    …al background image

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux
    susnux committed May 21, 2024
    Configuration menu
    Copy the full SHA
    482395b View commit details
    Browse the repository at this point in the history

  6. feat(theming): Allow users to configure their primary color 

    Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux
    susnux committed May 21, 2024
    Configuration menu
    Copy the full SHA
    4d865fd View commit details
    Browse the repository at this point in the history

  7. fix(theming): Also apply new background colors to guest view 

    Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux
    susnux committed May 21, 2024
    Configuration menu
    Copy the full SHA
    282f1b1 View commit details
    Browse the repository at this point in the history

  8. fix(tests): Adjust theming test for new splitted background and prima… 

    …ry colors

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux
    susnux committed May 21, 2024
    Configuration menu
    Copy the full SHA
    0ef3147 View commit details
    Browse the repository at this point in the history

  9. fix(core): Adjust styles for header menu icons 

    Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux
    susnux committed May 21, 2024
    Configuration menu
    Copy the full SHA
    c826092 View commit details
    Browse the repository at this point in the history

  10. fix(settings): Make background selector be responsive to user changes 

    Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux
    susnux committed May 21, 2024
    Configuration menu
    Copy the full SHA
    752e3b9 View commit details
    Browse the repository at this point in the history

  11. fix(styles): Adjust background stylings 

    Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux
    susnux committed May 21, 2024
    Configuration menu
    Copy the full SHA
    bd73bcc View commit details
    Browse the repository at this point in the history

  12. fix: cleanup theming app code 

    Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux
    susnux committed May 21, 2024
    Configuration menu
    Copy the full SHA
    8028784 View commit details
    Browse the repository at this point in the history

  13. fix: Always populate --image-background 

    Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux
    susnux committed May 21, 2024
    Configuration menu
    Copy the full SHA
    85b64e1 View commit details
    Browse the repository at this point in the history

  14. fix(settings): Return mean color of background image on set 

    Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux
    susnux committed May 21, 2024
    Configuration menu
    Copy the full SHA
    11dbfa6 View commit details
    Browse the repository at this point in the history

  15. fix(tests): Adjust theming test for new splitted background and prima… 

    …ry colors

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux
    susnux committed May 21, 2024
    Configuration menu
    Copy the full SHA
    538a049 View commit details
    Browse the repository at this point in the history

  16. fix(theming): Add some strict checking for userId 

    Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux
    susnux committed May 21, 2024
    Configuration menu
    Copy the full SHA
    f19d586 View commit details
    Browse the repository at this point in the history

  17. chore: Compile assets 

    Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux
    susnux committed May 21, 2024
    Configuration menu
    Copy the full SHA
    651afb8 View commit details
    Browse the repository at this point in the history