fix(files): Improve inaccessible files message in file reference widget - #42936
Merged
AndyScherzinger merged 2 commits intoJan 30, 2024
Merged
Conversation
jancborchardt
left a comment
jancborchardt
left a comment
Member
There was a problem hiding this comment.
Seems fine to me but maybe @nimishavijay for double-checking native language.
Maybe better than "gone" could be "The file could not be found […]" for example
mejo-
force-pushed
the
fix/files_reference_widget_inaccessible_wording
branch
from
January 29, 2024 11:46
daaab91 to
a80bd06
Compare
Member
Author
Agreed, changed now. |
juliusknorr
approved these changes
Jan 29, 2024
provokateurin
approved these changes
Jan 30, 2024
Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
fix/files_reference_widget_inaccessible_wording
branch
from
January 30, 2024 10:50
a80bd06 to
6c7080b
Compare
Member
Author
|
/compile |
miaulalala
approved these changes
Jan 30, 2024
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
AndyScherzinger
deleted the
fix/files_reference_widget_inaccessible_wording
branch
January 30, 2024 12:54
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change got discussed with @juliushaertl and the design team.
Checklist