Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use showError in TransferOwnershipDialogue #42720

Merged
merged 2 commits into from
Jan 16, 2024
Merged

use showError in TransferOwnershipDialogue #42720

merged 2 commits into from
Jan 16, 2024
+6 −6

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Jan 11, 2024 •
edited
Loading

Close #42592

For my own testing 
docker run -it --rm ^
--name nextcloud-easy-test ^
-p 8443:443 ^
-e SERVER_BRANCH=enh/42592/use-notecard ^
-e COMPILE_SERVER=1 ^
--volume="nextcloud_easy_test_npm_cache_volume:/var/www/.npm" ^
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added design Design, UI, UX, etc. 2. developing Work in progress accessibility labels Jan 11, 2024
@szaimen szaimen added this to the Nextcloud 29 milestone Jan 11, 2024
@szaimen
Copy link
Contributor Author

szaimen commented Jan 11, 2024

Idea is to show a toast in these cases iirc...

@szaimen szaimen force-pushed the enh/42592/use-notecard branch from 9f30c68 to fc5e9ef Compare January 16, 2024 10:47
@szaimen szaimen changed the title use NcNoteCard instead of custom error field use showError in TransferOwnershipDialogue Jan 16, 2024
@szaimen szaimen marked this pull request as ready for review January 16, 2024 10:54
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 16, 2024
@szaimen
use showError in TransferOwnershipDialogue
816d529 
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen force-pushed the enh/42592/use-notecard branch from fc5e9ef to 816d529 Compare January 16, 2024 13:06
@szaimen
Copy link
Contributor Author

szaimen commented Jan 16, 2024

/compile

@szaimen szaimen enabled auto-merge January 16, 2024 13:06
@nextcloud-command
chore(assets): Recompile assets
3c54925 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@szaimen
Copy link
Contributor Author

szaimen commented Jan 16, 2024

/skjnldsv-backport 816d529 to stable28

@szaimen szaimen merged commit 5aa799c into master Jan 16, 2024
41 checks passed
@szaimen szaimen deleted the enh/42592/use-notecard branch January 16, 2024 15:06
@backportbot backportbot bot mentioned this pull request Jan 16, 2024
Merged
1 task
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux susnux approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@Pytal Pytal Awaiting requested review from Pytal

@emoral435 emoral435 Awaiting requested review from emoral435

Assignees
No one assigned
Labels
3. to review Waiting for reviews accessibility design Design, UI, UX, etc.
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

[BITV]: Note regarding FilePicker is not accessible
4 participants
@szaimen @susnux @ShGKme @nextcloud-command