Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix header-elements being not shown correctly #42712

Merged
merged 2 commits into from
Jan 11, 2024
Merged

fix header-elements being not shown correctly #42712

merged 2 commits into from
Jan 11, 2024

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Jan 11, 2024 •
edited
Loading

Fix #42620

Before

recordedVideo2024-01-11-151620.mp4

After

recordedVideo2024-01-11-151407.mp4
For my own testing 
docker run -it --rm ^
--name nextcloud-easy-test ^
-p 8443:443 ^
--volume="nextcloud_easy_test_npm_cache_volume:/var/www/.npm" ^
-e SERVER_BRANCH=enh/42620/header-menues ^
-e COMPILE_SERVER=1 ^
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added bug design Design, UI, UX, etc. 2. developing Work in progress regression labels Jan 11, 2024
@szaimen szaimen added this to the Nextcloud 29 milestone Jan 11, 2024
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 11, 2024
@szaimen szaimen marked this pull request as ready for review January 11, 2024 14:17
@szaimen szaimen force-pushed the enh/42620/header-menues branch from b35bd28 to 6acc2b3 Compare January 11, 2024 16:10
@szaimen szaimen enabled auto-merge January 11, 2024 16:18
@szaimen
Copy link
Contributor Author

szaimen commented Jan 11, 2024

Needs a rebase...

@szaimen
fix header-elements being not shown correctly
a96a7f0 
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen force-pushed the enh/42620/header-menues branch from 4904897 to dfc2e61 Compare January 11, 2024 21:36
@szaimen
Copy link
Contributor Author

szaimen commented Jan 11, 2024

/backport a96a7f0 to stable28

@szaimen
Copy link
Contributor Author

szaimen commented Jan 11, 2024

/compile amend /

@nextcloud-command
chore(assets): Recompile assets
1054770 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@szaimen szaimen merged commit cbc9452 into master Jan 11, 2024
41 checks passed
@szaimen szaimen deleted the enh/42620/header-menues branch January 11, 2024 22:14
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 11, 2024
Merged
@ShGKme

This comment was marked as outdated.

Sign in to view
@ShGKme ShGKme mentioned this pull request Jan 19, 2024
Closed
@szaimen

This comment was marked as outdated.

Sign in to view
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emoral435 emoral435 emoral435 approved these changes

@Pytal Pytal Pytal approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@susnux susnux susnux approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. regression
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

Some themes not correclty inverting the header icons anymore
7 participants
@szaimen @ShGKme @susnux @JuliaKirschenheuter @Pytal @emoral435 @nextcloud-command