-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SharingEntrySimple
needs ul
or ol
around it
#42709
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
changed the title
sharing-entry__reshare needs ul or ol around it
Jan 11, 2024
sharing-entry__reshare
needs ul
or ol
around it
szaimen
changed the title
Jan 11, 2024
sharing-entry__reshare
needs ul
or ol
around itSharingEntrySimple
needs ul
or ol
around it
szaimen
changed the title
Jan 11, 2024
SharingEntrySimple
needs ul
or ol
around itSharingEntrySimple
needs ul
or ol
around it
szaimen
added
3. to review
Waiting for reviews
and removed
2. developing
Work in progress
labels
Jan 11, 2024
szaimen
requested review from
susnux,
JuliaKirschenheuter,
artonge,
Pytal,
ShGKme and
emoral435
January 11, 2024 13:36
ShGKme
approved these changes
Jan 11, 2024
emoral435
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Simon L <szaimen@e.mail.de>
szaimen
force-pushed
the
enh/42694/put-li-into-ul
branch
from
January 11, 2024 14:10
5a3c4af
to
420b3d0
Compare
/backport 420b3d0 to stable28 |
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #42694
This is best reviewed like this: https://github.com/nextcloud/server/pull/42709/files?diff=unified&w=1
For my own testing