Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(comments): Add visual labels for editor #42676

Merged
merged 2 commits into from
Jan 12, 2024
Merged

enh(comments): Add visual labels for editor #42676

merged 2 commits into from
Jan 12, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jan 10, 2024 •
edited
Loading

Summary

Add visual labels for the comments input.

Screenshot_20240110_020151
Screenshot_20240110_020311

Checklist

@susnux susnux added 3. to review Waiting for reviews accessibility labels Jan 10, 2024
@susnux susnux added this to the Nextcloud 29 milestone Jan 10, 2024
@susnux susnux force-pushed the enh/visible-comment-label branch from 18f8cca to e3f3d4a Compare January 10, 2024 09:58
@susnux susnux requested a review from artonge January 10, 2024 09:59
@susnux susnux force-pushed the enh/visible-comment-label branch from e3f3d4a to ac4f4e4 Compare January 10, 2024 11:10
@susnux susnux requested a review from ShGKme January 10, 2024 11:10
@susnux susnux requested a review from emoral435 January 11, 2024 08:20
emoral435
emoral435 approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my local dev env, looks good to me :) just needs the backport, unfortunately it seems like the backport bot is still snoozing a bit ;/ haha

susnux added 2 commits January 12, 2024 14:39
@susnux
enh(comments): Add always visible labels for comment input
cc59a4d 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Compile assets
e24f35d 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the enh/visible-comment-label branch from ac4f4e4 to e24f35d Compare January 12, 2024 14:05
@susnux susnux merged commit b9e3e6f into master Jan 12, 2024
42 checks passed
@susnux susnux deleted the enh/visible-comment-label branch January 12, 2024 15:01
@susnux
Copy link
Contributor Author

susnux commented Jan 12, 2024

/backport cc59a4d to stable28

@susnux
Copy link
Contributor Author

susnux commented Jan 12, 2024

/backport to stable28

1 similar comment
@susnux
Copy link
Contributor Author

susnux commented Jan 12, 2024

/backport to stable28

@susnux
Copy link
Contributor Author

susnux commented Jan 12, 2024

/backport cc59a4d to stable28

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 12, 2024
Merged
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@emoral435 emoral435 emoral435 approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@artonge artonge Awaiting requested review from artonge

Assignees
No one assigned
Labels
3. to review Waiting for reviews accessibility
Projects
None yet
Milestone
Nextcloud 29
3 participants
@susnux @ShGKme @emoral435