-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh(settings): Refactor UI for session and app token management #42334
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, and looked over the code - Looks good to me, really nice PR, however, best for others to also agree with my opinion :) 👍
Hi there :) Really nice UI improvement, thanks a lot ! |
Why are there so many sessions? Do you keep using them? If not they probably should be better revoked? (Maybe we need a batch / select-all-and-revoke action?). But yes, moving to the top will be possible. |
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
489c4e1
to
63a2453
Compare
/backport 960bec9 to stable28 |
Hi, did you? This would be really a good move - most ppl probably have a ton of open sessions and having to scroll down for this makes no sense. It should ideally be always on top, not below the sessions. As a matter of fact, I think this belongs in the 2FA settings... it is for use with 2FA, is it not? @nextcloud/designers |
Sorry, don't mean to be negative, it was very important that this was redesigned, but if it's not made more visible it still won't be used by people. Honestly, there should imho simply be a big button completely on top of the user security settings that says something like "log in with QR code or app password" and when you press it, it shows the QR code you can then just scan with your mobile phone. Even better, we should simply show the QR code on top of the personal security settings, always, or if that is not possible or horribly insecure, have it shown as a static blurred image you can click to show the actual QR code. We support this feature, it is prominent on the phone, showing you can scan a QR instead of entering all those details, but no user will realistically ever find WHERE TO SCAN THE QR CODE! The app password is secondary - show QR first, always. And maybe the app password below it. Steps to log in using QR now:
It should be:
That would make it easy and practical to use for many, perhaps even most users... Another idea: show it also on the "about" screen. Just show the users' qr code and tell them - scan this with your phone - it links to app store, then scan a 2nd time after installing the app and you are logged in. Bet it's not possible, but if it is... we should do it! |
I agree with @jospoortvliet. It should be easier to get to the qr code. What about having a general QR Code or a shortcut on the /index.php/settings/user/sync-clients page. I don't see much value there but a collection of links. I think this is the best fitting place for an QR Code to quickly log in with a mobile device and has the advantage that it not overcrowds the security page... Just an idea, I have no idea if it is feasible :) |
Summary
This modernizes the auth token / app password / app token (what ever name you like) UI:
Screenshots
Checklist