Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): Partly revert 32c1aeb and show correct quota again #42186

Merged
merged 1 commit into from
Dec 14, 2023
Merged

fix(files): Partly revert 32c1aeb and show correct quota again #42186

merged 1 commit into from
Dec 14, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Dec 13, 2023 •
edited
Loading

Summary

Fix units used for the quota shown in the files app back to base 2 as in all previous versions.

Screenshots

Setting the Quota to 10MB (10 * 1024 * 1024 bytes):

before after
Screenshot_20231213_025339 Screenshot_20231213_025516

Checklist

@susnux susnux requested review from skjnldsv, a team, sorbaugh and emoral435 and removed request for a team December 13, 2023 01:52
@susnux
Copy link
Contributor Author

susnux commented Dec 13, 2023

/backport to stable28

@susnux susnux requested a review from Pytal December 13, 2023 01:53
@susnux susnux force-pushed the fix/files-quota-nav branch 2 times, most recently from c5ea40c to fd70dee Compare December 13, 2023 11:10
emoral435
emoral435 approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't currently check on my local dev ENV but LGTM!

@susnux @emoral435
fix(files): Partly revert 32c1aeb and show correct quota again
2d5d782 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
Copy link
Contributor Author

susnux commented Dec 14, 2023

drone (samba) unrelated

@susnux susnux disabled auto-merge December 14, 2023 19:37
@susnux susnux merged commit 5d7b6f1 into master Dec 14, 2023
40 of 41 checks passed
@susnux susnux deleted the fix/files-quota-nav branch December 14, 2023 19:37
@susnux
Copy link
Contributor Author

susnux commented Dec 14, 2023

/backport to stable28

@susnux susnux mentioned this pull request Dec 15, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 1, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@emoral435 emoral435 emoral435 approved these changes

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-frontend

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review Waiting for reviews backport-request bug feature: files regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wrong user quota in the user administration
3 participants
@susnux @skjnldsv @emoral435