Skip to content

Adapt "advanced settings" button for accordion button #41473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2023
Merged

Adapt "advanced settings" button for accordion button #41473

merged 1 commit into from
Nov 15, 2023

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Nov 14, 2023 •
edited
Loading

Summary

Relied on https://www.w3.org/WAI/ARIA/apg/patterns/accordion/ and https://www.w3.org/WAI/ARIA/apg/patterns/accordion/examples/accordion/

Before

Peek 2023-11-06 14-37

After

Peek 2023-11-14 18-43

Checklist

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Nov 14, 2023
@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Nov 14, 2023
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/41306-Sharing_tab_There_is_no_indicator_that_advanced_settings_are_open branch from b010fe3 to 1f3a7ec Compare November 14, 2023 18:03
@JuliaKirschenheuter @susnux
Adapt "advanced settings" button for accordion button
7c987f0 
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@susnux susnux force-pushed the fix/41306-Sharing_tab_There_is_no_indicator_that_advanced_settings_are_open branch from 1f3a7ec to 7c987f0 Compare November 15, 2023 08:09
@susnux
Copy link
Contributor

susnux commented Nov 15, 2023

cypress unrelated

@susnux susnux merged commit bd483e7 into master Nov 15, 2023
@susnux susnux deleted the fix/41306-Sharing_tab_There_is_no_indicator_that_advanced_settings_are_open branch November 15, 2023 09:49
@blizzz blizzz mentioned this pull request Nov 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@Pytal Pytal Pytal approved these changes

@ShGKme ShGKme ShGKme approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@szaimen szaimen Awaiting requested review from szaimen

@nfebe nfebe Awaiting requested review from nfebe

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BITV]: Sharing tab: There is no indicator that "advanced settings" are open
5 participants
@JuliaKirschenheuter @susnux @Pytal @ShGKme @marcoambrosini