sidebar: allow turning off tags view by default

[pulsejet]

With #37065, there is no way to hide the tags from the sidebar by default when they are not relevant or redundant (e.g. the tab may already show the file's tags). This can be annyoing especially when the file has many tags. This patch adds an option to hide the tags from the sidebar by default (the user can still open the tags tab manually).

This also reduces one request when opening the sidebar when the tags are turned off, since all tags don't need to be fetched anymore.

Screenshot: tags are redundant and take up a lot of space.

[artonge]

This won't be persisted, right ?

[pulsejet]

This won't be persisted, right ?

Yeah, a reload will switch it back to showing the tags again (current behavior). But I expect the app to call this method to not show the tags on load.

[Pytal]

With #37065, there is no way to hide the tags from the sidebar by default when they are not relevant or redundant (e.g. the tab may already show the file's tags).

Worked this way actually since legacy times :)

[pulsejet]

Worked this way actually since legacy times :)

Well there was OCA.SystemTags.View.toggle(). Technically you could combine that with a MutationObserver ...

[pulsejet]

/compile amend /

[Pytal]

Well there was OCA.SystemTags.View.toggle(). Technically you could combine that with a MutationObserver ...

🤯, I suppose default was the same then

[pulsejet]

🤯, I suppose default was the same then

Yeah you're right. I think I never noticed it before cause the tags component was rather small 🤔

[pulsejet]

/compile amend /

[pulsejet]

Any reason this was ignored for 28?

[artonge]

Beside red CI, I see no reason :)

[pulsejet]

/compile amend /

[pulsejet]

@artonge I've a general question: is it okay if I enable auto-merge on my PRs? I've been not doing the merges myself because I don't work for Nextcloud; not sure how I'm supposed to go about this.

EDIT: Well, this one failed on an unrelated CI error, so I can't merge anyway 🤷🏻(it's not required)

EDIT2: another issue is the quick merge conflict that arises

[artonge]

is it okay if I enable auto-merge on my PRs?

Sure, but some CI steps are not required to auto-merge, so the merge won't get blocked if they don't pass. If you're confident that all tests will pass then go for it :).

EDIT2: another issue is the quick merge conflict that arises

That's hard to do without. But if you have the needed approvals, and if CI failures are not related, ping one of us stating the situation, and we'll force merge for you.

[artonge]

You can also try to restart some failing CI steps. Note that for cypress, you need to restart all the steps and not only the failing ones.

[pulsejet]

/backport to stable28

[skjnldsv]

/skjnldsv-backport to stable28

[solracsf]

/backport to stable28

[backportbot]

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/40939/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick c5810245

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/40939/stable28

Error: Failed to push branch backport/40939/stable28: fatal: could not read Username for 'https://github.com': No such device or address

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

[solracsf]

/backport 424eb12 to stable28

[backportbot]

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/40939/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 424eb124

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/40939/stable28

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress
fatal: cherry-pick failed

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.