Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(search): Close unified search at the second ctrl+f #40890

Merged
merged 1 commit into from
Oct 16, 2023
Merged

fix(search): Close unified search at the second ctrl+f #40890

merged 1 commit into from
Oct 16, 2023

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Oct 12, 2023 •
edited
Loading

Maybe I'm too stupid by I find myself in the same situation every time I want to find something on a Nextcloud page

  1. I press ctrl+f
  2. I type my search string
  3. I realize search went into Nextcloud's unified search. Useful but not what I wanted.
  4. I click ctrl+f again (because I know it will be handled by the browser now)
  5. I type my search string

master: the browser finds my string in the unified search
here: the browser finds my string in the main content

Before After
Bildschirmfoto vom 2023-10-12 18-23-44 Bildschirmfoto vom 2023-10-12 18-23-06

Summary

Closes the unified search menu when the user clicks ctrl+f while the menu is open.

TODO

  • ...

Checklist

@ChristophWurst ChristophWurst added bug 3. to review Waiting for reviews papercut Annoying recurring issue with possibly simple fix. labels Oct 12, 2023
@ChristophWurst ChristophWurst self-assigned this Oct 12, 2023
nimishavijay
nimishavijay approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agreed! 🚀

@ChristophWurst ChristophWurst force-pushed the fix/search/close-unified-search-second-ctrl-f branch from f34a8e1 to f8107a4 Compare October 13, 2023 07:46
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 13, 2023
@ChristophWurst
Copy link
Member Author

/backport to stable27

susnux
susnux approved these changes Oct 15, 2023
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hint: Use F3 ;)

@ChristophWurst @susnux
fix(search): Close unified search at the second ctrl+f
7d13e95 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@susnux susnux force-pushed the fix/search/close-unified-search-second-ctrl-f branch from f8107a4 to 7d13e95 Compare October 15, 2023 22:30
@susnux susnux enabled auto-merge October 15, 2023 22:30
jancborchardt
jancborchardt approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely agree, ran into this as well but forgot to open an issue – thanks a lot for the fix! :)

@ChristophWurst
Copy link
Member Author

CI fails because the tests run so long, Nextcloud is asking for password confirmation.

@ChristophWurst ChristophWurst merged commit 0321bec into master Oct 16, 2023
40 checks passed
@ChristophWurst ChristophWurst deleted the fix/search/close-unified-search-second-ctrl-f branch October 16, 2023 14:05
@ChristophWurst
Copy link
Member Author

/backport to stable27

@ChristophWurst
Copy link
Member Author

/backport to stable26

@ChristophWurst
Copy link
Member Author

/backport to stable27

@ChristophWurst
Copy link
Member Author

/backport to stable26

@ChristophWurst
Copy link
Member Author

/backport to stable27

@ChristophWurst
Copy link
Member Author

/backport to stable26

@ChristophWurst
Copy link
Member Author

So be it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimishavijay nimishavijay nimishavijay approved these changes

@Pytal Pytal Pytal approved these changes

@susnux susnux susnux approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@sorbaugh sorbaugh Awaiting requested review from sorbaugh

Assignees

@ChristophWurst ChristophWurst

Labels
4. to release Ready to be released and/or waiting for tests to finish bug papercut Annoying recurring issue with possibly simple fix.
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ChristophWurst @jancborchardt @susnux @Pytal @nimishavijay