Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove space #40700

Closed
wants to merge 3 commits into from
Closed

Remove space #40700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8bbdea1
Remove space
Valdnet Sep 29, 2023
a4e7d1c
chore(assets): Recompile assets
nextcloud-command Sep 29, 2023
c9e53be
Update apps/files_sharing/src/views/SharingDetailsTab.vue
Valdnet Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/files_sharing/src/views/SharingDetailsTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@

computed: {
title() {
let title = t('files_sharing', 'Share with ')
let title = t('files_sharing', 'Share with') + " "

Check failure on line 281 in apps/files_sharing/src/views/SharingDetailsTab.vue

View workflow job for this annotation

GitHub Actions / eslint 

Strings must use singlequote
if (this.share.type === this.SHARE_TYPES.SHARE_TYPE_USER) {
title = title + this.share.shareWithDisplayName
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per https://docs.nextcloud.com/server/latest/developer_manual/basics/front-end/l10n.html#improving-your-translations this is not good.
It would be better to have a full t() in each of the else-if branches?

} else if (this.share.type === this.SHARE_TYPES.SHARE_TYPE_LINK) {
Expand Down
3 changes: 3 additions & 0 deletions dist/4815-4815.js
View file
Open in desktop

Large diffs are not rendered by default.

0 dist/485-485.js.LICENSE.txt → dist/4815-4815.js.LICENSE.txt
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions dist/4815-4815.js.map
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 0 additions & 3 deletions dist/485-485.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion dist/485-485.js.map
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions dist/files_sharing-files_sharing_tab.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/files_sharing-files_sharing_tab.js.map
View file
Open in desktop

Large diffs are not rendered by default.

Loading