Theming fixes #405
Merged
Theming fixes #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
force-pushed
the
theming-fixes
branch
from
4f8c8be to
1a1e33d
Compare
nickvergessen
added
2. developing
nickvergessen
force-pushed
the
theming-fixes
branch
from
1a1e33d to
f35b696
Compare
Merged
2 tasks
|
@nickvergessen Is this ready to review? |
|
|
||
| // setup realm | ||
| $defaults = new \OC_Defaults(); | ||
| $defaults = new \OCP\Defaults(); |
There was a problem hiding this comment.
any reasons why we don't use \OC::$server->getThemingDefaults() here and below?
There was a problem hiding this comment.
getThemingDefaults() is marked as internal, and the constructor of OCP\Default uses this internal method after this PR.
nickvergessen
added
3. to review
|
Yes, ready for review |
|
|
||
| public function getShortFooter() { | ||
| $slogan = $this->getSlogan(); | ||
| $footer = '<a href="'. $this->getBaseUrl() . '" target="_blank"' . |
There was a problem hiding this comment.
No? Or atleast this is just copy paste of the parent class, so it would need fixing there as.
|
Tested and works 👍 Code looks good |
|
looks good 👍 |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://help.nextcloud.com/t/absender-von-freigabelinks/1620
Should backport to 9.0: #406
@LukasReschke @MorrisJobke @schiessle