feat: Add dedicated method to load init scripts #40323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
requested review from
a team,
come-nc,
mejo-,
skjnldsv and
sorbaugh
and removed request for
a team
skjnldsv
reviewed
Sep 7, 2023
skjnldsv
approved these changes
Sep 7, 2023
juliusknorr
force-pushed
the
enh/init-scripts
branch
from
bbcdd61 to
a679b19
Compare
skjnldsv
approved these changes
Sep 7, 2023
come-nc
approved these changes
Sep 7, 2023
skjnldsv
added
4. to release
come-nc
reviewed
Sep 7, 2023
Signed-off-by: Julius Härtl <jus@bitgrid.net> Co-authored-by: John Molakvoæ <skjnldsv@protonmail.com> Update lib/public/Util.php Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
enh/init-scripts
branch
from
af117a1 to
bd65f1e
Compare
ChristophWurst
added
the
pending documentation
|
this new feature needs docs |
|
juliusknorr
removed
the
pending documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During development on text I noticed that the new files2vue file list is loading too fast and fetching the file list before text has even had a chance to register additional dav properties on the initial page load.
This adds a method to allow apps registering init scripts which are loaded first (even before any core javascript). They need to be handled with care, but I indicated that also on the phpdoc comment.
Change itself is from @skjnldsv, I just shaped it to a pull request.
Example usage: nextcloud/text@0eb23bb
Checklist