fix(dav): use quota of destination in s3 chunk upload #39672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: #39228. Check the free space on the destination. Before it was checking the free space on `$storage` which is the upload storage of the user who triggered the upload. This led to user quota being applied even when uploading to a share with unlimited space. Signed-off-by: Max <max@nextcloud.com>
|
/backport to stable27 |
|
/backport to stable26 |
juliushaertl
approved these changes
Aug 2, 2023
blizzz
approved these changes
Aug 2, 2023
blizzz
added
the
4. to release
This was referenced Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Check the free space on the destination.
Before it was checking the free space on
$storagewhich is the upload storage of the user who triggered the upload. This led to user quota being appliedeven when uploading to a share with unlimited space.
Checklist