Skip to content

fix!: Remove symfony EventDispatcherInterface from OC\User and OC\Group #39595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 28, 2023
Merged

fix!: Remove symfony EventDispatcherInterface from OC\User and OC\Group #39595

merged 3 commits into from
Jul 28, 2023
+95 −210

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jul 27, 2023 •
edited
Loading

Checklist

@nickvergessen nickvergessen added 3. to review Waiting for reviews technical debt pending documentation This pull request needs an associated documentation update labels Jul 27, 2023
@nickvergessen nickvergessen added this to the Nextcloud 28 milestone Jul 27, 2023
@nickvergessen nickvergessen self-assigned this Jul 27, 2023
@nickvergessen nickvergessen requested review from ArtificialOwl and nfebe and removed request for a team July 27, 2023 17:02
@nickvergessen nickvergessen force-pushed the bugfix/noid/remove-symfony-event-from-user branch from e739f83 to f1cc66f Compare July 27, 2023 17:08
@nickvergessen
fix!: Remove symfony EventDispatcherInterface from User
ad12a74 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix!: Remove symfony EventDispatcherInterface from Group
80f79e1 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix: Align doc type with creation
030e8d8 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/remove-symfony-event-from-user branch from 359a6bb to 030e8d8 Compare July 27, 2023 21:13
@nickvergessen nickvergessen mentioned this pull request Jul 27, 2023
Merged
4 tasks
@nickvergessen nickvergessen merged commit f3bdcfd into master Jul 28, 2023
@nickvergessen nickvergessen deleted the bugfix/noid/remove-symfony-event-from-user branch July 28, 2023 08:40
@nickvergessen nickvergessen mentioned this pull request Jul 28, 2023
Merged
15 tasks
@nickvergessen nickvergessen removed the pending documentation This pull request needs an associated documentation update label Jul 28, 2023
@nickvergessen
Copy link
Member Author

Docs in nextcloud/documentation#10858

@nickvergessen nickvergessen mentioned this pull request Jul 31, 2023
Closed
@juliusknorr juliusknorr mentioned this pull request Aug 7, 2023
Closed
@skjnldsv skjnldsv mentioned this pull request Aug 11, 2023
Closed
@gino0631 gino0631 mentioned this pull request Dec 13, 2023
Closed
@illnesse
Copy link

any idea how to stop the metadata app from spamming the log with "Call to undefined method OC\Server::getEventDispatcher()" errors? is that something that needs fixing in the app?

@come-nc
Copy link
Contributor

come-nc commented Jan 2, 2024

any idea how to stop the metadata app from spamming the log with "Call to undefined method OC\Server::getEventDispatcher()" errors? is that something that needs fixing in the app?

Yes, the app is not yet released for 28.
See gino0631/nextcloud-metadata#106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@nfebe nfebe nfebe approved these changes

@julien-nc julien-nc Awaiting requested review from julien-nc

@come-nc come-nc Awaiting requested review from come-nc

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

Assignees

@nickvergessen nickvergessen

Labels

3. to review Waiting for reviews technical debt

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

6 participants

@nickvergessen @illnesse @come-nc @ChristophWurst @nfebe