Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using the profiler to selectively profile production instances #39399

Closed
wants to merge 13 commits into from

Conversation

icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Jul 14, 2023

  • Fix app loading events not being ended correctly
  • Fix legacy dav endpoints not being profiled
  • Fix clearing profiles
  • Add option to enable the profiler for a specific request using a shared secret in the request params
    • This is similar to the logic that exists to enable debug logging per request
    • This doesn't require the profiler app to be enabled and can thus be used to collect some profiles in production and then analyse them offline
    • More options for triggering the profiler should be added later (per user, per url, etc). But for now the shared secret will do as a POC

todo:

  • move the data collectors to core so profiles without the profiler app enabled have more info
  • move some of the occ profiler:* commands to core so profiles can be exported without requiring the profiler app.
  • should we instead split up the profiler app into a front and backend? Where we can release/ship the backend without having to release the frontend

@icewind1991 icewind1991 added the 2. developing Work in progress label Jul 14, 2023
@icewind1991 icewind1991 added this to the Nextcloud 28 milestone Jul 14, 2023
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
… for legacy dav endpoints

Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 changed the title Profiler improvements Allow using the profiler to selectively profile production instances Sep 17, 2023
Signed-off-by: Robin Appelman <robin@icewind.nl>
core/Command/Profiler/Clear.php Fixed Show fixed Hide fixed
core/Command/Profiler/Disable.php Fixed Show fixed Hide fixed
core/Command/Profiler/Enable.php Fixed Show fixed Hide fixed
core/Command/Profiler/Export.php Fixed Show fixed Hide fixed
core/Command/Profiler/ListCommand.php Fixed Show fixed Hide fixed
core/Command/Profiler/ListCommand.php Fixed Show fixed Hide fixed
core/Command/Profiler/ListCommand.php Fixed Show fixed Hide fixed
core/Command/Profiler/ListCommand.php Fixed Show fixed Hide fixed
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 marked this pull request as ready for review September 17, 2023 10:54
@icewind1991 icewind1991 requested review from a team, ArtificialOwl, Fenn-CS and sorbaugh and removed request for a team September 17, 2023 10:54
@icewind1991 icewind1991 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 17, 2023
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
This was referenced Mar 12, 2024
@skjnldsv
Copy link
Member

conflicts

@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 15, 2024
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Mar 15, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 30 milestone Mar 15, 2024
@skjnldsv skjnldsv marked this pull request as draft March 15, 2024 15:02
@susnux susnux added this to the Nextcloud 30 milestone Apr 18, 2024
@skjnldsv skjnldsv closed this Aug 14, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants