Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve translations api with detecting languages #38003

Merged
merged 2 commits into from
May 3, 2023
Merged

Improve translations api with detecting languages #38003

merged 2 commits into from
May 3, 2023

Conversation

nickvergessen
Copy link
Member

Summary

  1. Fix a bug that when the first translation provider was unable to detect a language translations would not work
  2. Return the from language (on success and error) so that clients can select the proper option and/or give hints to the user how they can get closer to a translation

Checklist

@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels May 1, 2023
@nickvergessen nickvergessen added this to the Nextcloud 27 milestone May 1, 2023
@nickvergessen nickvergessen self-assigned this May 1, 2023
@nickvergessen nickvergessen changed the title Bugfix/noid/improve translations api Improve translations api with detecting languages May 1, 2023
@nickvergessen
fix(translation): Detect the language first and then ask all provider…
dc67b48 
…s for translations

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
feat(translation): Return the detected language so clients can show m…
9d6ec68 
…ore details

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/improve-translations-api branch from 29c7957 to 9d6ec68 Compare May 2, 2023 14:38
@skjnldsv skjnldsv mentioned this pull request May 3, 2023
Merged
@nickvergessen nickvergessen merged commit 9ace8e5 into master May 3, 2023
@nickvergessen nickvergessen deleted the bugfix/noid/improve-translations-api branch May 3, 2023 09:07
This was referenced May 4, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelklehr marcelklehr marcelklehr approved these changes

@vitormattos vitormattos vitormattos approved these changes

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @marcelklehr @vitormattos