Skip to content

Conversation

@nickvergessen
Copy link
Member

Summary

Ignores extra apps, vendor and more when optimizing images

Checklist

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

For me this posts:

appscommunity/ is not shipped. Ignoring image optimization
appsmarketing/ is not shipped. Ignoring image optimization
appsmine/ is not shipped. Ignoring image optimization
appspackaged/ is not shipped. Ignoring image optimization
appssubscriptions/ is not shipped. Ignoring image optimization
appssupported/ is not shipped. Ignoring image optimization
appszips/ is not shipped. Ignoring image optimization
output/ is not shipped. Ignoring image optimization
vendor/ is not shipped. Ignoring image optimization
node_modules/ is not shipped. Ignoring image optimization

:)

So only #36014 remaining afterwards

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes a lot of sense, thanks! :)

@nickvergessen nickvergessen merged commit b21c5c8 into master Apr 17, 2023
@nickvergessen nickvergessen deleted the techdebt/ref-37476/ignore-excluded-dirs-on-image-optimization branch April 17, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants