Reduce share ID casts

[provokateurin]

Summary

Split out from #37390

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[come-nc]

Also, doing (int)$string will convert to string even if the string is weird, like '10km' will convert to 10. Here if someone tries to call an API method on an invalid share id, it should return an error, not silently work with another share id. So I would add tests for is_numeric and error out if it’s not.

[blizzz]

Cannot judge. I have the impression that there is a mixture of int and string uses on IDs still.

[provokateurin]

Also, doing (int)$string will convert to string even if the string is weird, like '10km' will convert to 10. Here if someone tries to call an API method on an invalid share id, it should return an error, not silently work with another share id. So I would add tests for is_numeric and error out if it’s not.

This stuff is already done in the setId implementation, but it just fails silently. Before the path was like string -> (int) -> (string) and I removed that extra cast to int.

[provokateurin]

Cannot judge. I have the impression that there is a mixture of int and string uses on IDs still.

I know, I tried fixing it, but it's not completely possible.

[provokateurin]

@come-nc @blizzz I should have made more clear what this PR is about. I'm trying to minimize the amounts of casts that happen everywhere for share ids. They get changed quite often because different places use either string or int. IShare uses string, so I converted some places to also use string instead of casting to int and then back to string.

[blizzz]

Please excuse the dumb question, i am not familiar with all the aspects there, but going string everywhere, as by API design, is not possible?

[provokateurin]

I think we can do that in most cases. Internally the id is an integer in the database so there needs to be some casting at least. We'd need to make sure that the output of API calls stay integer if they are integers right now. One downside I see is that devs might not be aware that the ids should be valid integers, but then the code is a mess anyway, so it's not much worse.