Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implemented Sorting of shares by title and then creation date #37470

Closed
wants to merge 3 commits into from
Closed

implemented Sorting of shares by title and then creation date #37470

wants to merge 3 commits into from

Conversation

SamantaTarun
Copy link

@SamantaTarun SamantaTarun commented Mar 29, 2023 •
edited
Loading

Summary

Uploading Screenshot at 2023-03-30 01-12-51.png…

TODO

  • ...

Checklist

@SamantaTarun
implemented Sorting of shares by title and then creation date
c79eac4 
Signed-off-by: Tarun Samanta <tarunsamanta77@gmail.com>
@szaimen szaimen added this to the Nextcloud 27 milestone Mar 29, 2023
@szaimen szaimen added the 3. to review Waiting for reviews label Mar 29, 2023
@szaimen szaimen requested review from a team, artonge, skjnldsv and Pytal and removed request for a team March 29, 2023 20:23
@SamantaTarun
fixed lint issues
dd84ec4 
Signed-off-by: Tarun Samanta <tarunsamanta77@gmail.com>
artonge
artonge reviewed Mar 30, 2023
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we want that as the initial sort logic seem on purpose. @nextcloud/designers any thought on it ?
@tarunsamanta2k20 Also, the screenshot was not uploaded correctly ;)

@SamantaTarun
Copy link
Author

@artonge i will upload the screen shot again in some time. I have tested it it's working fine.

@SamantaTarun
Update SharingTab.vue
28c9797 
Signed-off-by: Tarun Samanta <55488549+tarunsamanta2k20@users.noreply.github.com>
This was referenced May 3, 2023
Merged
Closed
Merged
@SamantaTarun
Copy link
Author

@skjnldsv

Not sure if we want that as the initial sort logic seem on purpose. @nextcloud/designers any thought on it ? @tarunsamanta2k20 Also, the screenshot was not uploaded correctly ;)

@artonge let me upload the screenshot.

@jancborchardt
Copy link
Member

Sorry, what's the short summary of the change and the use-case?

The sorting should be the same across the different views, just like in a desktop file manager. So if "All" are sorted by name, "Shared" should be too. Same for "Modified" etc.

@blizzz blizzz mentioned this pull request May 17, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv was automatically assigned from nextcloud/server-frontend

@Pytal Pytal Awaiting requested review from Pytal Pytal was automatically assigned from nextcloud/server-frontend

@artonge artonge Awaiting requested review from artonge

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
5 participants
@SamantaTarun @jancborchardt @artonge @blizzz @szaimen