fix right-click menu for open locally #37295
Conversation
Signed-off-by: Simon L <szaimen@e.mail.de>
szaimen
force-pushed
the
enh/noid/fix-rightlick-open-locally
branch
from
7ce7139
to
09f2919
Compare
| var locked = context.$file.data('locked'); | ||
| if (!locked) { | ||
| return OC.imagePath('files', 'computer.svg') | ||
| return 'icon-computer' |
There was a problem hiding this comment.
doesnt seem to work yet...
| } | ||
| }, | ||
| mime: 'all', | ||
| order: -23, | ||
| icon: function(filename, context) { | ||
| iconClass: function(filename, context) { |
There was a problem hiding this comment.
@Pytal changing to iconClass seems to make it visible in the right-click menu. However I still need to find out how to add the icon-computer class then.
There was a problem hiding this comment.
Instead of adding icon-computer which is the deprecated way, would probably be better to make it work with the icon property
There was a problem hiding this comment.
I fear that this would need to be fixed in the horrible rightclick app and unfortunately I dont see an easy way to achieve this in there :/
@skjlndsv would it be fine for now to create a new icon-computer class until it gets rewritten with vue?
|
What issue does this fix? The "Edit locally" action shows up correctly on NC26 |
Not in the right-clik menu afaics... |
| @@ -716,15 +716,15 @@ | |||
| displayName: function(context) { | |||
| var locked = context.$file.data('locked'); | |||
| if (!locked) { | |||
| return t('files', 'Edit locally'); | |||
| return t('files', 'Open locally'); | |||
There was a problem hiding this comment.
Should we change the wording from "Edit" to "Open" @jancborchardt?
|
Not relevant anymore |
For my own testing