Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix json_decode expecting a string #36895

Merged
merged 1 commit into from
May 8, 2023
Merged

Fix json_decode expecting a string #36895

merged 1 commit into from
May 8, 2023

Conversation

apasov
Copy link
Contributor

@apasov apasov commented Feb 28, 2023

@apasov
Update Checker.php
3a11f91 
Signed-off-by: Ilya Apasov <apasov@users.noreply.github.com>
@szaimen szaimen added bug 3. to review Waiting for reviews labels Feb 28, 2023
@szaimen szaimen added this to the Nextcloud 26 milestone Feb 28, 2023
@szaimen szaimen requested review from ChristophWurst, a team, ArtificialOwl, icewind1991 and blizzz and removed request for a team February 28, 2023 20:20
@ChristophWurst ChristophWurst removed their request for review March 1, 2023 07:04
@solracsf

This comment was marked as resolved.

Sign in to view
@ChristophWurst
Copy link
Member

The $json parameter is typed string

@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 7, 2023
@skjnldsv skjnldsv mentioned this pull request May 3, 2023
Merged
@solracsf solracsf changed the title fixes #36894 Fix json_decode expecting a string May 8, 2023
@solracsf
Copy link
Member

solracsf commented May 8, 2023

/backport to stable26

@solracsf
Copy link
Member

solracsf commented May 8, 2023

/backport to stable25

@blizzz blizzz merged commit c7bb540 into nextcloud:master May 8, 2023
@welcome
Copy link

welcome bot commented May 8, 2023

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 8, 2023
Merged
@solracsf
Copy link
Member

solracsf commented May 9, 2023

/backport to stable25

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 9, 2023
Merged
This was referenced May 9, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icewind1991 icewind1991 icewind1991 approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@blizzz blizzz Awaiting requested review from blizzz blizzz was automatically assigned from nextcloud/server-backend

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.

[Bug]: error when upgrading from 25.0.3 to 25.0.4
7 participants
@apasov @solracsf @ChristophWurst @icewind1991 @blizzz @skjnldsv @szaimen