Refactors tests/app.php to improve code readability. #36742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsamapoor
changed the title
szaimen
requested review from
a team,
ArtificialOwl,
icewind1991 and
blizzz
and removed request for
a team
Merged
Merged
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
fsamapoor
force-pushed
the
patch-1
branch
2 times, most recently
from
4299b15
to
b6df4ed
Compare
|
Hello @come-nc, This has been going unnoticed for 6 months! |
come-nc
approved these changes
Aug 28, 2023
|
@artonge Sorry to bother. This has been around for a very long time. Could you please review it? |
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves the readability of the "loadDirectory" function by extending guard clauses and early returns and reducing the code indentation.