Skip to content

perf(bundles): Improve nextcloud-vue import to only load components once #36383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

perf(bundles): Improve nextcloud-vue import to only load components once #36383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9857943
perf(bundles): Improve import to only load components once
juliusknorr Jan 26, 2023
48921d2
fix: Revert NcHighlight import for now
juliusknorr Feb 1, 2023
d99da9f
fix: Revert some non exported ones
juliusknorr Feb 6, 2023
54c3537
chore: Fix build warnings
juliusknorr Feb 13, 2023
b76817f
chore: remove unused @nextcloud/vue-dashboard
juliusknorr Feb 13, 2023
2165d1b
tests: Fix jest transforms
juliusknorr Feb 13, 2023
7023d12
chore: Bump @nextcloud/dialogs and nextcloud-vue-collections
juliusknorr Feb 13, 2023
bf30aee
chore(webpack): Move to node-polyfill-webpack-plugin
juliusknorr Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions apps/comments/src/components/Comment.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,7 @@
import { getCurrentUser } from '@nextcloud/auth'
import moment from '@nextcloud/moment'

import NcActionButton from '@nextcloud/vue/dist/Components/NcActionButton'
import NcActions from '@nextcloud/vue/dist/Components/NcActions'
import NcActionSeparator from '@nextcloud/vue/dist/Components/NcActionSeparator'
import NcAvatar from '@nextcloud/vue/dist/Components/NcAvatar'
import NcButton from '@nextcloud/vue/dist/Components/NcButton'
import NcRichContenteditable from '@nextcloud/vue/dist/Components/NcRichContenteditable'
import RichEditorMixin from '@nextcloud/vue/dist/Mixins/richEditor'
import { NcActionButton, NcActions, NcActionSeparator, NcAvatar, NcButton, NcRichContenteditable, richEditor } from '@nextcloud/vue'
import ArrowRight from 'vue-material-design-icons/ArrowRight'

import Moment from './Moment'
Expand All @@ -129,7 +123,7 @@ export default {
Moment,
NcRichContenteditable,
},
mixins: [RichEditorMixin, CommentMixin],
mixins: [richEditor, CommentMixin],

inheritAttrs: false,

Expand Down
3 changes: 1 addition & 2 deletions apps/comments/src/views/Comments.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,7 @@ import axios from '@nextcloud/axios'
import VTooltip from 'v-tooltip'
import Vue from 'vue'

import NcEmptyContent from '@nextcloud/vue/dist/Components/NcEmptyContent'
import NcButton from '@nextcloud/vue/dist/Components/NcButton'
import { NcEmptyContent, NcButton } from '@nextcloud/vue'
import RefreshIcon from 'vue-material-design-icons/Refresh'
import MessageReplyTextIcon from 'vue-material-design-icons/MessageReplyText'
import AlertCircleOutlineIcon from 'vue-material-design-icons/AlertCircleOutline'
Expand Down
3 changes: 1 addition & 2 deletions apps/dashboard/src/DashboardApp.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,8 @@ import { generateUrl } from '@nextcloud/router'
import { getCurrentUser } from '@nextcloud/auth'
import { loadState } from '@nextcloud/initial-state'
import axios from '@nextcloud/axios'
import NcButton from '@nextcloud/vue/dist/Components/NcButton'
import { NcButton, NcModal } from '@nextcloud/vue'
import Draggable from 'vuedraggable'
import NcModal from '@nextcloud/vue/dist/Components/NcModal'
import Pencil from 'vue-material-design-icons/Pencil.vue'
import Vue from 'vue'

Expand Down
2 changes: 1 addition & 1 deletion apps/dashboard/src/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
import Vue from 'vue'
import DashboardApp from './DashboardApp.vue'
import { translate as t } from '@nextcloud/l10n'
import VTooltip from '@nextcloud/vue/dist/Directives/Tooltip'
import { Tooltip as VTooltip } from '@nextcloud/vue'
import { getRequestToken } from '@nextcloud/auth'

// eslint-disable-next-line camelcase
Expand Down
8 changes: 3 additions & 5 deletions apps/dav/src/views/Availability.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,12 @@ import {
findScheduleInboxAvailability,
getEmptySlots,
saveScheduleInboxAvailability,
} from '../service/CalendarService'
} from '../service/CalendarService.js'
import {
enableUserStatusAutomation,
disableUserStatusAutomation,
} from '../service/PreferenceService'
import NcButton from '@nextcloud/vue/dist/Components/NcButton'
import NcCheckboxRadioSwitch from '@nextcloud/vue/dist/Components/NcCheckboxRadioSwitch'
import NcSettingsSection from '@nextcloud/vue/dist/Components/NcSettingsSection'
} from '../service/PreferenceService.js'
import { NcButton, NcCheckboxRadioSwitch, NcSettingsSection } from '@nextcloud/vue'
import NcTimezonePicker from '@nextcloud/vue/dist/Components/NcTimezonePicker'

export default {
Expand Down
3 changes: 1 addition & 2 deletions apps/dav/src/views/CalDavSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,7 @@
import axios from '@nextcloud/axios'
import { generateUrl } from '@nextcloud/router'
import { loadState } from '@nextcloud/initial-state'
import NcSettingsSection from '@nextcloud/vue/dist/Components/NcSettingsSection'
import NcCheckboxRadioSwitch from '@nextcloud/vue/dist/Components/NcCheckboxRadioSwitch'
import { NcSettingsSection, NcCheckboxRadioSwitch } from '@nextcloud/vue'

const userSyncCalendarsDocUrl = loadState('dav', 'userSyncCalendarsDocUrl', '#')

Expand Down
3 changes: 1 addition & 2 deletions apps/federatedfilesharing/src/components/AdminSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,7 @@
</template>

<script>
import NcCheckboxRadioSwitch from '@nextcloud/vue/dist/Components/NcCheckboxRadioSwitch'
import NcSettingsSection from '@nextcloud/vue/dist/Components/NcSettingsSection'
import { NcCheckboxRadioSwitch, NcSettingsSection } from '@nextcloud/vue'
import { loadState } from '@nextcloud/initial-state'
import { showError } from '@nextcloud/dialogs'
import axios from '@nextcloud/axios'
Expand Down
3 changes: 1 addition & 2 deletions apps/federatedfilesharing/src/components/PersonalSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
<script>
import { showError, showSuccess } from '@nextcloud/dialogs'
import { loadState } from '@nextcloud/initial-state'
import NcSettingsSection from '@nextcloud/vue/dist/Components/NcSettingsSection'
import NcButton from '@nextcloud/vue/dist/Components/NcButton'
import { NcSettingsSection, NcButton } from '@nextcloud/vue'
import Twitter from 'vue-material-design-icons/Twitter'
import Facebook from 'vue-material-design-icons/Facebook'
import Web from 'vue-material-design-icons/Web'
Expand Down
3 changes: 1 addition & 2 deletions apps/files/src/components/NavigationQuota.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ import { debounce, throttle } from 'throttle-debounce'
import { translate } from '@nextcloud/l10n'
import axios from '@nextcloud/axios'
import ChartPie from 'vue-material-design-icons/ChartPie.vue'
import NcAppNavigationItem from '@nextcloud/vue/dist/Components/NcAppNavigationItem.js'
import NcProgressBar from '@nextcloud/vue/dist/Components/NcProgressBar.js'
import { NcAppNavigationItem, NcProgressBar } from '@nextcloud/vue'

import logger from '../logger.js'
import { subscribe } from '@nextcloud/event-bus'
Expand Down
3 changes: 1 addition & 2 deletions apps/files/src/components/SidebarTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@
</template>

<script>
import NcAppSidebarTab from '@nextcloud/vue/dist/Components/NcAppSidebarTab'
import NcEmptyContent from '@nextcloud/vue/dist/Components/NcEmptyContent'
import { NcAppSidebarTab, NcEmptyContent } from '@nextcloud/vue'

export default {
name: 'SidebarTab',
Expand Down
3 changes: 1 addition & 2 deletions apps/files/src/components/TransferOwnershipDialogue.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,8 @@ import axios from '@nextcloud/axios'
import debounce from 'debounce'
import { generateOcsUrl } from '@nextcloud/router'
import { getFilePickerBuilder, showSuccess } from '@nextcloud/dialogs'
import NcMultiselect from '@nextcloud/vue/dist/Components/NcMultiselect'
import { NcMultiselect, NcButton } from '@nextcloud/vue'
import Vue from 'vue'
import NcButton from '@nextcloud/vue/dist/Components/NcButton'

import logger from '../logger'

Expand Down
3 changes: 1 addition & 2 deletions apps/files/src/views/Navigation.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,7 @@ import { translate } from '@nextcloud/l10n'

import axios from '@nextcloud/axios'
import Cog from 'vue-material-design-icons/Cog.vue'
import NcAppNavigation from '@nextcloud/vue/dist/Components/NcAppNavigation.js'
import NcAppNavigationItem from '@nextcloud/vue/dist/Components/NcAppNavigationItem.js'
import { NcAppNavigation, NcAppNavigationItem } from '@nextcloud/vue'

import logger from '../logger.js'
import Navigation from '../services/Navigation.ts'
Expand Down
6 changes: 2 additions & 4 deletions apps/files/src/views/Settings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,9 @@
</template>

<script>
import NcAppSettingsDialog from '@nextcloud/vue/dist/Components/NcAppSettingsDialog.js'
import NcAppSettingsSection from '@nextcloud/vue/dist/Components/NcAppSettingsSection.js'
import NcCheckboxRadioSwitch from '@nextcloud/vue/dist/Components/NcCheckboxRadioSwitch.js'
import { NcAppSettingsDialog, NcAppSettingsSection, NcCheckboxRadioSwitch } from '@nextcloud/vue'
import NcInputField from '@nextcloud/vue/dist/Components/NcInputField.js'
import Clipboard from 'vue-material-design-icons/Clipboard.vue'
import NcInputField from '@nextcloud/vue/dist/Components/NcInputField'
import Setting from '../components/Setting.vue'

import { emit } from '@nextcloud/event-bus'
Expand Down
4 changes: 1 addition & 3 deletions apps/files/src/views/Sidebar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,7 @@ import { emit } from '@nextcloud/event-bus'
import moment from '@nextcloud/moment'
import { Type as ShareTypes } from '@nextcloud/sharing'

import NcAppSidebar from '@nextcloud/vue/dist/Components/NcAppSidebar'
import NcActionButton from '@nextcloud/vue/dist/Components/NcActionButton'
import NcEmptyContent from '@nextcloud/vue/dist/Components/NcEmptyContent'
import { NcAppSidebar, NcActionButton, NcEmptyContent } from '@nextcloud/vue'

import FileInfo from '../services/FileInfo'
import SidebarTab from '../components/SidebarTab'
Expand Down
3 changes: 1 addition & 2 deletions apps/files/src/views/TemplatePicker.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,7 @@
<script>
import { normalize } from 'path'
import { showError } from '@nextcloud/dialogs'
import NcEmptyContent from '@nextcloud/vue/dist/Components/NcEmptyContent'
import NcModal from '@nextcloud/vue/dist/Components/NcModal'
import { NcEmptyContent, NcModal } from '@nextcloud/vue'

import { getCurrentDirectory } from '../utils/davUtils'
import { createFromTemplate, getTemplates } from '../services/Templates'
Expand Down
3 changes: 1 addition & 2 deletions apps/files_sharing/src/collaborationresources.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@

import Vue from 'vue'
import Vuex from 'vuex'
import NcPopoverMenu from '@nextcloud/vue/dist/Components/NcPopoverMenu'
import Tooltip from '@nextcloud/vue/dist/Directives/Tooltip'
import { NcPopoverMenu, Tooltip } from '@nextcloud/vue'
import ClickOutside from 'vue-click-outside'

import View from './views/CollaborationView'
Expand Down
4 changes: 1 addition & 3 deletions apps/files_sharing/src/components/SharePermissionsEditor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,7 @@
</template>

<script>
import NcActionButton from '@nextcloud/vue/dist/Components/NcActionButton'
import NcActionRadio from '@nextcloud/vue/dist/Components/NcActionRadio'
import NcActionCheckbox from '@nextcloud/vue/dist/Components/NcActionCheckbox'
import { NcActionButton, NcActionRadio, NcActionCheckbox } from '@nextcloud/vue'

import SharesMixin from '../mixins/SharesMixin'
import {
Expand Down
7 changes: 1 addition & 6 deletions apps/files_sharing/src/components/SharingEntry.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,12 +137,7 @@
</template>

<script>
import NcAvatar from '@nextcloud/vue/dist/Components/NcAvatar'
import NcActions from '@nextcloud/vue/dist/Components/NcActions'
import NcActionButton from '@nextcloud/vue/dist/Components/NcActionButton'
import NcActionCheckbox from '@nextcloud/vue/dist/Components/NcActionCheckbox'
import NcActionInput from '@nextcloud/vue/dist/Components/NcActionInput'
import NcActionTextEditable from '@nextcloud/vue/dist/Components/NcActionTextEditable'
import { NcAvatar, NcActions, NcActionButton, NcActionCheckbox, NcActionInput, NcActionTextEditable } from '@nextcloud/vue'

import SharesMixin from '../mixins/SharesMixin.js'

Expand Down
5 changes: 1 addition & 4 deletions apps/files_sharing/src/components/SharingEntryInherited.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,7 @@
<script>
import { generateUrl } from '@nextcloud/router'
import { basename } from '@nextcloud/paths'
import NcAvatar from '@nextcloud/vue/dist/Components/NcAvatar'
import NcActionButton from '@nextcloud/vue/dist/Components/NcActionButton'
import NcActionLink from '@nextcloud/vue/dist/Components/NcActionLink'
import NcActionText from '@nextcloud/vue/dist/Components/NcActionText'
import { NcAvatar, NcActionButton, NcActionLink, NcActionText } from '@nextcloud/vue'

// eslint-disable-next-line no-unused-vars
import Share from '../models/Share'
Expand Down
2 changes: 1 addition & 1 deletion apps/files_sharing/src/components/SharingEntryInternal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<script>
import { generateUrl } from '@nextcloud/router'
import { showSuccess } from '@nextcloud/dialogs'
import NcActionLink from '@nextcloud/vue/dist/Components/NcActionLink'
import { NcActionLink } from '@nextcloud/vue'
import SharingEntrySimple from './SharingEntrySimple'

export default {
Expand Down
10 changes: 1 addition & 9 deletions apps/files_sharing/src/components/SharingEntryLink.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,15 +281,7 @@ import { showError, showSuccess } from '@nextcloud/dialogs'
import { Type as ShareTypes } from '@nextcloud/sharing'
import Vue from 'vue'

import NcActionButton from '@nextcloud/vue/dist/Components/NcActionButton'
import NcActionCheckbox from '@nextcloud/vue/dist/Components/NcActionCheckbox'
import NcActionInput from '@nextcloud/vue/dist/Components/NcActionInput'
import NcActionLink from '@nextcloud/vue/dist/Components/NcActionLink'
import NcActionText from '@nextcloud/vue/dist/Components/NcActionText'
import NcActionSeparator from '@nextcloud/vue/dist/Components/NcActionSeparator'
import NcActionTextEditable from '@nextcloud/vue/dist/Components/NcActionTextEditable'
import NcActions from '@nextcloud/vue/dist/Components/NcActions'
import NcAvatar from '@nextcloud/vue/dist/Components/NcAvatar'
import { NcActionButton, NcActionCheckbox, NcActionInput, NcActionLink, NcActionText, NcActionSeparator, NcActionTextEditable, NcActions, NcAvatar } from '@nextcloud/vue'

import ExternalShareAction from './ExternalShareAction.vue'
import SharePermissionsEditor from './SharePermissionsEditor.vue'
Expand Down
6 changes: 3 additions & 3 deletions apps/files_sharing/src/components/SharingEntrySimple.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@
{{ subtitle }}
</p>
</div>
<NcActions ref="actionsComponent"
v-if="$slots['default']"
<NcActions v-if="$slots['default']"
ref="actionsComponent"
class="sharing-entry__actions"
menu-align="right"
:aria-expanded="ariaExpandedValue">
Expand All @@ -40,7 +40,7 @@
</template>

<script>
import NcActions from '@nextcloud/vue/dist/Components/NcActions'
import { NcActions } from '@nextcloud/vue'

export default {
name: 'SharingEntrySimple',
Expand Down
2 changes: 1 addition & 1 deletion apps/files_sharing/src/components/SharingInput.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ import { generateOcsUrl } from '@nextcloud/router'
import { getCurrentUser } from '@nextcloud/auth'
import axios from '@nextcloud/axios'
import debounce from 'debounce'
import NcSelect from '@nextcloud/vue/dist/Components/NcSelect.js'
import { NcSelect } from '@nextcloud/vue'

import Config from '../services/ConfigService'
import GeneratePassword from '../utils/GeneratePassword'
Expand Down
2 changes: 1 addition & 1 deletion apps/files_sharing/src/views/SharingInherited.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@

<script>
import { generateOcsUrl } from '@nextcloud/router'
import NcActionButton from '@nextcloud/vue/dist/Components/NcActionButton'
import { NcActionButton } from '@nextcloud/vue'
import axios from '@nextcloud/axios'

import Share from '../models/Share'
Expand Down
2 changes: 1 addition & 1 deletion apps/files_sharing/src/views/SharingTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
<script>
import { CollectionList } from 'nextcloud-vue-collections'
import { generateOcsUrl } from '@nextcloud/router'
import NcAvatar from '@nextcloud/vue/dist/Components/NcAvatar'
import { NcAvatar } from '@nextcloud/vue'
import axios from '@nextcloud/axios'
import { loadState } from '@nextcloud/initial-state'

Expand Down
3 changes: 1 addition & 2 deletions apps/oauth2/src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,7 @@ import axios from '@nextcloud/axios'
import OAuthItem from './components/OAuthItem'
import { generateUrl } from '@nextcloud/router'
import { getCapabilities } from '@nextcloud/capabilities'
import NcSettingsSection from '@nextcloud/vue/dist/Components/NcSettingsSection'
import NcButton from '@nextcloud/vue/dist/Components/NcButton'
import { NcSettingsSection, NcButton } from '@nextcloud/vue'
import { loadState } from '@nextcloud/initial-state'

export default {
Expand Down
2 changes: 1 addition & 1 deletion apps/oauth2/src/components/OAuthItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
<script>

import Delete from 'vue-material-design-icons/Delete'
import NcButton from '@nextcloud/vue/dist/Components/NcButton'
import { NcButton } from '@nextcloud/vue'

export default {
name: 'OAuthItem',
Expand Down
2 changes: 1 addition & 1 deletion apps/settings/src/components/AdminDelegating.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

<script>
import GroupSelect from './AdminDelegation/GroupSelect'
import NcSettingsSection from '@nextcloud/vue/dist/Components/NcSettingsSection'
import { NcSettingsSection } from '@nextcloud/vue'
import { loadState } from '@nextcloud/initial-state'

export default {
Expand Down
2 changes: 1 addition & 1 deletion apps/settings/src/components/AdminDelegation/GroupSelect.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
</template>

<script>
import NcMultiselect from '@nextcloud/vue/dist/Components/NcMultiselect'
import { NcMultiselect } from '@nextcloud/vue'
import { generateUrl } from '@nextcloud/router'
import axios from '@nextcloud/axios'
import { showError } from '@nextcloud/dialogs'
Expand Down
5 changes: 1 addition & 4 deletions apps/settings/src/components/AdminTwoFactor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,7 @@

<script>
import axios from '@nextcloud/axios'
import NcMultiselect from '@nextcloud/vue/dist/Components/NcMultiselect'
import NcButton from '@nextcloud/vue/dist/Components/NcButton'
import NcCheckboxRadioSwitch from '@nextcloud/vue/dist/Components/NcCheckboxRadioSwitch'
import NcSettingsSection from '@nextcloud/vue/dist/Components/NcSettingsSection'
import { NcMultiselect, NcButton, NcCheckboxRadioSwitch, NcSettingsSection } from '@nextcloud/vue'
import { loadState } from '@nextcloud/initial-state'

import _ from 'lodash'
Expand Down
2 changes: 1 addition & 1 deletion apps/settings/src/components/AppDetails.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@
</template>

<script>
import NcMultiselect from '@nextcloud/vue/dist/Components/NcMultiselect'
import { NcMultiselect } from '@nextcloud/vue'

import AppManagement from '../mixins/AppManagement'
import PrefixMixin from './PrefixMixin'
Expand Down
2 changes: 1 addition & 1 deletion apps/settings/src/components/AppList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
import AppItem from './AppList/AppItem'
import PrefixMixin from './PrefixMixin'
import pLimit from 'p-limit'
import NcButton from '@nextcloud/vue/dist/Components/NcButton'
import { NcButton } from '@nextcloud/vue'

export default {
name: 'AppList',
Expand Down
2 changes: 1 addition & 1 deletion apps/settings/src/components/AppList/AppItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
import AppScore from './AppScore.vue'
import AppManagement from '../../mixins/AppManagement.js'
import SvgFilterMixin from '../SvgFilterMixin.vue'
import NcButton from '@nextcloud/vue/dist/Components/NcButton.js'
import { NcButton } from '@nextcloud/vue'

export default {
name: 'AppItem',
Expand Down
2 changes: 1 addition & 1 deletion apps/settings/src/components/AuthTokenSetupDialogue.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ import { confirmPassword } from '@nextcloud/password-confirmation'
import '@nextcloud/password-confirmation/dist/style.css'
import { showError } from '@nextcloud/dialogs'
import { getRootUrl } from '@nextcloud/router'
import NcButton from '@nextcloud/vue/dist/Components/NcButton'
import { NcButton } from '@nextcloud/vue'

import Check from 'vue-material-design-icons/Check.vue'
import ContentCopy from 'vue-material-design-icons/ContentCopy.vue'
Expand Down
4 changes: 1 addition & 3 deletions apps/settings/src/components/BasicSettings/BackgroundJob.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,7 @@
<script>
import { loadState } from '@nextcloud/initial-state'
import { showError } from '@nextcloud/dialogs'
import NcCheckboxRadioSwitch from '@nextcloud/vue/dist/Components/NcCheckboxRadioSwitch.js'
import NcSettingsSection from '@nextcloud/vue/dist/Components/NcSettingsSection.js'
import NcNoteCard from '@nextcloud/vue/dist/Components/NcNoteCard.js'
import { NcCheckboxRadioSwitch, NcSettingsSection, NcNoteCard } from '@nextcloud/vue'
import moment from '@nextcloud/moment'
import axios from '@nextcloud/axios'
import { generateOcsUrl } from '@nextcloud/router'
Expand Down
Loading