Skip to content

Don't reuse query builder object with populated parameters in FederatedShareProvider #36267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2023
Merged

Don't reuse query builder object with populated parameters in FederatedShareProvider #36267

merged 1 commit into from
Feb 6, 2023

Conversation

nickvergessen
Copy link
Member

Found in #36261

Checklist

@nickvergessen nickvergessen added this to the Nextcloud 26 milestone Jan 20, 2023
@nickvergessen nickvergessen requested review from a team and PVince81 January 20, 2023 09:49
@nickvergessen nickvergessen self-assigned this Jan 20, 2023
@nickvergessen nickvergessen requested review from ArtificialOwl and icewind1991 and removed request for a team January 20, 2023 09:49
@nickvergessen
Copy link
Member Author

/backport to stable25

@nickvergessen
Copy link
Member Author

/backport to stable24

@nickvergessen nickvergessen mentioned this pull request Jan 20, 2023
Merged
4 tasks
PVince81
PVince81 approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nickvergessen
Don't reuse query builder object with populated parameters
f717219 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/dont-reuse-query-builder branch from 283c240 to f717219 Compare January 23, 2023 06:05
@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@nickvergessen nickvergessen merged commit fa1d50c into master Feb 6, 2023
@nickvergessen nickvergessen deleted the bugfix/noid/dont-reuse-query-builder branch February 6, 2023 20:14
@blizzz blizzz mentioned this pull request Feb 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

+1 more reviewer

@vitormattos vitormattos vitormattos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nickvergessen nickvergessen

Labels

3. to review Waiting for reviews bug feature: sharing

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen @PVince81 @vitormattos