Skip to content

Fix theming migration repair step by passing correct type for argument #36069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2023
Merged

Fix theming migration repair step by passing correct type for argument #36069

merged 1 commit into from
Jan 11, 2023

Conversation

@come-nc
Copy link
Contributor

@come-nc come-nc commented Jan 10, 2023 •
edited
Loading

Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com

Summary

The migration step to migrate background image in 25 had a type error.

Checklist

@come-nc
Fix theming migration repair step by passing correct type for argument
09099cf 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc added bug 3. to review Waiting for reviews labels Jan 10, 2023
@come-nc come-nc added this to the Nextcloud 25.0.3 milestone Jan 10, 2023
@come-nc come-nc requested a review from blizzz January 10, 2023 14:02
@come-nc come-nc self-assigned this Jan 10, 2023
@szaimen szaimen requested review from a team, ArtificialOwl and icewind1991 and removed request for a team January 10, 2023 14:08
@szaimen
Copy link
Contributor

szaimen commented Jan 10, 2023

@come-nc does this fix #35871?

PVince81
PVince81 approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Member

/backport to stable25

@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 10, 2023
@PVince81 PVince81 merged commit a9f92b6 into master Jan 11, 2023
@PVince81 PVince81 deleted the fix/fix-theming-repair-step branch January 11, 2023 08:15
This was referenced Jan 11, 2023
Merged
Merged
@PVince81
Copy link
Member

stable25: #36081

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

@SystemKeeper SystemKeeper mentioned this pull request Jan 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

Assignees

@come-nc come-nc

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Milestone

Nextcloud 25.0.3

Development

Successfully merging this pull request may close these issues.

[theming] TypeError: Cannot access offset of type string on string in MigrateBackgroundImages.php

5 participants

@come-nc @szaimen @PVince81 @skjnldsv